Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/ --- (Updated Nov. 5, 2015, 4:26 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/ --- (Updated Nov. 5, 2015, 6:04 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/#review105370 --- Ship it! Ship It! - Guangya Liu On εδΈ€ζœˆ 5, 2015, 6:04 p.m.,

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/#review105191 --- src/master/master.cpp (lines 6004 - 6008)

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-04 Thread Ben Mahler
> On Nov. 4, 2015, 2:43 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 6039 > > > > > > Why not have the same logic here to be defensive? Or do you intend to > > guard against it? Just seems weird to

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-04 Thread Vinod Kone
> On Nov. 4, 2015, 2:43 a.m., Ben Mahler wrote: > > src/master/master.cpp, lines 6004-6013 > > > > > > Just looking at the patch that introduced this bug, why are we removing > > the out-of-order update

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-03 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/#review105027 --- src/master/master.cpp (lines 6004 - 6008)

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/#review104779 --- src/master/master.cpp (lines 6024 - 6028)

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/ --- (Updated Nov. 2, 2015, 9:50 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Vinod Kone
> On Nov. 2, 2015, 8:13 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 6032-6036 > > > > > > The movement around this seems to be the key part of this patch, is it > > possible to isolate the fix in a

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/ --- (Updated Nov. 2, 2015, 10:34 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/#review104836 --- Patch looks great! Reviews applied: [39791, 39792, 39827, 39878,