Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review108654 --- src/master/master.cpp (lines 3029 - 3030)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Jie Yu
> On Dec. 2, 2015, 4:05 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 3041-3043 > > > > > > We validate later on that in `principal` is `None`, reserve is aborted. > > IIUC, if `FrameworkInfo`

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Dec. 2, 2015, 7:55 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Greg Mann
> On Dec. 2, 2015, 4:05 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 3041-3043 > > > > > > We validate later on that in `principal` is `None`, reserve is aborted. > > IIUC, if `FrameworkInfo`

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Alexander Rukletsov
> On Dec. 2, 2015, 4:05 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 3041-3043 > > > > > > We validate later on that in `principal` is `None`, reserve is aborted. > > IIUC, if `FrameworkInfo`

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Dec. 2, 2015, 9:41 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review108515 --- src/master/master.cpp (lines 3190 - 3191)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review108401 --- Ship it! src/master/master.cpp (line 3191)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 30, 2015, 9:20 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 30, 2015, 8:48 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review107281 --- src/master/master.cpp (lines 3016 - 3028)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review107280 --- src/master/master.cpp (lines 3278 - 3288)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 20, 2015, 12:20 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-19 Thread Greg Mann
> On Nov. 14, 2015, 12:07 a.m., Jie Yu wrote: > > src/master/master.cpp, lines 3037-3049 > > > > > > Hum, this looks problematic to me. The authorization results are stored > > in 'futures'. The ordering in

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-19 Thread Greg Mann
> On Nov. 14, 2015, 12:07 a.m., Jie Yu wrote: > > src/master/master.cpp, lines 3037-3049 > > > > > > Hum, this looks problematic to me. The authorization results are stored > > in 'futures'. The ordering in

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-19 Thread Greg Mann
> On Nov. 14, 2015, 12:07 a.m., Jie Yu wrote: > > src/master/master.cpp, lines 3037-3049 > > > > > > Hum, this looks problematic to me. The authorization results are stored > > in 'futures'. The ordering in

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 17, 2015, 5:07 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-17 Thread Greg Mann
> On Nov. 14, 2015, 12:07 a.m., Jie Yu wrote: > > src/master/master.cpp, lines 3037-3049 > > > > > > Hum, this looks problematic to me. The authorization results are stored > > in 'futures'. The ordering in

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 13, 2015, 11:17 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 13, 2015, 9:15 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review106534 --- src/master/master.cpp (lines 3028 - 3040)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 13, 2015, 4:32 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review105714 --- Patch looks great! Reviews applied: [39985, 39986, 39987, 39988,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 9, 2015, 5:26 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 9, 2015, 6:13 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 9:08 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 2986 > > > > > > Why not "const TaskInfo& task"? Good catch! - Greg ---

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 6, 2015, 11:58 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review105549 --- Also need to update the docs. src/tests/reservation_tests.cpp

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review105572 --- Patch looks great! Reviews applied: [39985, 39986, 39987, 39988,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review105390 --- src/master/master.cpp (line 2977)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 5, 2015, 9:53 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review105346 --- Patch looks great! Reviews applied: [39985, 39986, 39987, 39988,