Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106732 --- Bad patch! Reviews applied: [40285] Failed command:

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/ --- (Updated Nov. 16, 2015, 8:49 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106775 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106403 --- Patch looks great! Reviews applied: [40285] All tests passed. -

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106435 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-13 Thread Jojy Varghese
> On Nov. 13, 2015, 4:49 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 78 > > > > > > This would then print the whole untar structure on every layer and > > every

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106457 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-13 Thread Timothy Chen
> On Nov. 13, 2015, 4:49 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 78 > > > > > > This would then print the whole untar structure on every layer and > > every

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-13 Thread Jojy Varghese
> On Nov. 13, 2015, 5:31 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 78 > > > > > > But the user then have to search the log around to see what's the tar's > >