Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 15, 2016, 1:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 15, 2016, 1:27 p.m.) Review request for mesos and Benjamin

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-15 Thread Michael Park
> On Dec. 21, 2015, 5:04 a.m., Michael Park wrote: > > src/common/http.cpp, lines 443-450 > > > > > > Currently in the `model` function for `CommandInfo`, the `extract` and > > `cache` fields of `CommandInfo::URI`

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-15 Thread Alexander Rojas
> On Jan. 14, 2016, 6:08 a.m., Alexander Rojas wrote: > > I was wondering what the results of the benchmark would be with an > > optimized build. > > Michael Park wrote: > The tests are already performed with an optimized build. So, are we moving towards optimized builds? because AFAIK

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-14 Thread Michael Park
> On Jan. 14, 2016, 5:08 a.m., Alexander Rojas wrote: > > I was wondering what the results of the benchmark would be with an > > optimized build. The tests are already performed with an optimized build. - Michael --- This is an

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 15, 2016, 7:41 a.m.) Review request for mesos and Benjamin

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-14 Thread Michael Park
> On Jan. 14, 2016, 4:25 a.m., Benjamin Hindman wrote: > > src/master/http.cpp, lines 135-146 > > > > > > A basic comment that implies that a `Summary` representation is for the > > '/state-summary' endpoints and

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/#review114416 --- I was wondering what the results of the benchmark would be with an

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/#review114432 --- Bad patch! Reviews applied: [41593] Failed command:

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/#review114402 --- Ship it! src/master/http.cpp (line 112)

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 5, 2016, 10:18 a.m.) Review request for mesos and Benjamin

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 6, 2016, 2:48 a.m.) Review request for mesos and Benjamin

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-05 Thread Michael Park
> On Dec. 21, 2015, 5:04 a.m., Michael Park wrote: > > src/master/http.cpp, lines 134-150 > > > > > > @benh: How does this pattern look to you? If you're ok with it, we > > should find a better home for it.

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 5, 2016, 10:39 p.m.) Review request for mesos and Benjamin