Re: Review Request 41840: Moved docker spec to the top level.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41840/#review112487 --- Ship it! Ship It! - Timothy Chen On Jan. 3, 2016, 6:30 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41840/ > --- > > (Updated Jan. 3, 2016, 6:30 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Moved docker spec to the top level. > > This is a part of a series patchs to clean up docker related code. > > > Diffs > - > > src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e > src/docker/v1.hpp PRE-CREATION > src/docker/v2.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/docker/message.hpp > 5c071432724f1c583b4dba1ed391e4af22c6ba8f > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp > e73d4d785bccf1d50af9e91d2d20dafb444bec68 > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 049d46cad5cf94a3fb5d74cbfe649850311d35ad > src/slave/containerizer/mesos/provisioner/docker/spec.hpp > 1bd4ac10373fd95d2a22658715c6dbf81fbb567f > src/slave/containerizer/mesos/provisioner/docker/spec.cpp > 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 > src/slave/containerizer/mesos/provisioner/docker/v1.proto > 5aec78b51726e4c840ffb47aacca0e1ec13c80d3 > src/slave/containerizer/mesos/provisioner/docker/v2.proto > fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 > src/tests/containerizer/provisioner_docker_tests.cpp > d51f342dabf386fb618ef72ce3e36a8bd8c82b5f > > Diff: https://reviews.apache.org/r/41840/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 41840: Moved docker spec to the top level.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41840/#review112483 --- Ship it! Ship It! - Gilbert Song On Jan. 3, 2016, 10:30 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41840/ > --- > > (Updated Jan. 3, 2016, 10:30 a.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Moved docker spec to the top level. > > This is a part of a series patchs to clean up docker related code. > > > Diffs > - > > src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e > src/docker/v1.hpp PRE-CREATION > src/docker/v2.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/docker/message.hpp > 5c071432724f1c583b4dba1ed391e4af22c6ba8f > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp > e73d4d785bccf1d50af9e91d2d20dafb444bec68 > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 049d46cad5cf94a3fb5d74cbfe649850311d35ad > src/slave/containerizer/mesos/provisioner/docker/spec.hpp > 1bd4ac10373fd95d2a22658715c6dbf81fbb567f > src/slave/containerizer/mesos/provisioner/docker/spec.cpp > 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 > src/slave/containerizer/mesos/provisioner/docker/v1.proto > 5aec78b51726e4c840ffb47aacca0e1ec13c80d3 > src/slave/containerizer/mesos/provisioner/docker/v2.proto > fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 > src/tests/containerizer/provisioner_docker_tests.cpp > d51f342dabf386fb618ef72ce3e36a8bd8c82b5f > > Diff: https://reviews.apache.org/r/41840/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 41840: Moved docker spec to the top level.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41840/ --- (Updated Jan. 3, 2016, 6:30 p.m.) Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Changes --- Added a missing include. Repository: mesos Description --- Moved docker spec to the top level. This is a part of a series patchs to clean up docker related code. Diffs (updated) - src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e src/docker/v1.hpp PRE-CREATION src/docker/v2.hpp PRE-CREATION src/slave/containerizer/mesos/provisioner/docker/message.hpp 5c071432724f1c583b4dba1ed391e4af22c6ba8f src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp e73d4d785bccf1d50af9e91d2d20dafb444bec68 src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 049d46cad5cf94a3fb5d74cbfe649850311d35ad src/slave/containerizer/mesos/provisioner/docker/spec.hpp 1bd4ac10373fd95d2a22658715c6dbf81fbb567f src/slave/containerizer/mesos/provisioner/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 src/slave/containerizer/mesos/provisioner/docker/v1.proto 5aec78b51726e4c840ffb47aacca0e1ec13c80d3 src/slave/containerizer/mesos/provisioner/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 src/tests/containerizer/provisioner_docker_tests.cpp d51f342dabf386fb618ef72ce3e36a8bd8c82b5f Diff: https://reviews.apache.org/r/41840/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 41840: Moved docker spec to the top level.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41840/ --- (Updated Jan. 3, 2016, 6:59 a.m.) Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Changes --- Fixed a few issue when SSL is enabled. Repository: mesos Description --- Moved docker spec to the top level. This is a part of a series patchs to clean up docker related code. Diffs (updated) - src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e src/docker/v1.hpp PRE-CREATION src/docker/v2.hpp PRE-CREATION src/slave/containerizer/mesos/provisioner/docker/message.hpp 5c071432724f1c583b4dba1ed391e4af22c6ba8f src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp e73d4d785bccf1d50af9e91d2d20dafb444bec68 src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 049d46cad5cf94a3fb5d74cbfe649850311d35ad src/slave/containerizer/mesos/provisioner/docker/spec.hpp 1bd4ac10373fd95d2a22658715c6dbf81fbb567f src/slave/containerizer/mesos/provisioner/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 src/slave/containerizer/mesos/provisioner/docker/v1.proto 5aec78b51726e4c840ffb47aacca0e1ec13c80d3 src/slave/containerizer/mesos/provisioner/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 src/tests/containerizer/provisioner_docker_tests.cpp d51f342dabf386fb618ef72ce3e36a8bd8c82b5f Diff: https://reviews.apache.org/r/41840/diff/ Testing --- make check Thanks, Jie Yu
