Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
>
> haosdent huang wrote:
> I think we could ignore this error message.
>
> Bernd Mathiske wrote:
> I'd rather not ignore the error message. How can there be an out-of-range
> char in HTML and CSS files?
>
> haosdent huang wrote:
> I afraid this may caused by boostrap have some special characters like
> `ok:before{content:"\e013"}`.
>
> Bernd Mathiske wrote:
> This should be an encoding using printable cahrs (<=128) only.
>
> haosdent huang wrote:
> LoL, seems `Michael Lunøe` cause the problem. Need fix the
> apply_reviews.py
>
> haosdent huang wrote:
> Need do changes in apply_reviews.py to support no-ascii commit messages.
> ```
> diff --git a/support/apply-reviews.py b/support/apply-reviews.py
> index ea5e43a..36bfb1e 100755
> --- a/support/apply-reviews.py
> +++ b/support/apply-reviews.py
> @@ -185,7 +185,7 @@ def commit_patch():
>else:
> amend = '-e'
>
> - cmd = 'git commit --author \'{author}\' {_amend} -am \'{message}\''\
> + cmd = u'git commit --author \'{author}\' {_amend} -am \'{message}\''\
> .format(author=quote(data['author']),
> _amend=amend,
> message=quote(data['message']))
> @@ -248,7 +248,7 @@ def reviewboard_data():
>user = url_to_json(reviewboard_user_url(
> review.get('links').get('submitter').get('title'))).get('user')
>
> - author = '{author} <{email}>'.format(author=user.get('fullname'),
> + author = u'{author} <{email}>'.format(author=user.get('fullname'),
> email=user.get('email'))
>message = '\n\n'.join(['{summary}',
>'{description}',
> ```
>
> Vinod Kone wrote:
> Thanks haosdent for the diff. I committed a patch based on this (and
> attributed it to you).
Where do I see this patch, so I know when to re-open this?
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
> - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
> - 1680 x 1050px screen:
> http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
> - 2880 x 1800px screen:
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
>
> haosdent huang wrote:
> I think we could ignore this error message.
>
> Bernd Mathiske wrote:
> I'd rather not ignore the error message. How can there be an out-of-range
> char in HTML and CSS files?
>
> haosdent huang wrote:
> I afraid this may caused by boostrap have some special characters like
> `ok:before{content:"\e013"}`.
>
> Bernd Mathiske wrote:
> This should be an encoding using printable cahrs (<=128) only.
>
> haosdent huang wrote:
> LoL, seems `Michael Lunøe` cause the problem. Need fix the
> apply_reviews.py
>
> haosdent huang wrote:
> Need do changes in apply_reviews.py to support no-ascii commit messages.
> ```
> diff --git a/support/apply-reviews.py b/support/apply-reviews.py
> index ea5e43a..36bfb1e 100755
> --- a/support/apply-reviews.py
> +++ b/support/apply-reviews.py
> @@ -185,7 +185,7 @@ def commit_patch():
>else:
> amend = '-e'
>
> - cmd = 'git commit --author \'{author}\' {_amend} -am \'{message}\''\
> + cmd = u'git commit --author \'{author}\' {_amend} -am \'{message}\''\
> .format(author=quote(data['author']),
> _amend=amend,
> message=quote(data['message']))
> @@ -248,7 +248,7 @@ def reviewboard_data():
>user = url_to_json(reviewboard_user_url(
> review.get('links').get('submitter').get('title'))).get('user')
>
> - author = '{author} <{email}>'.format(author=user.get('fullname'),
> + author = u'{author} <{email}>'.format(author=user.get('fullname'),
> email=user.get('email'))
>message = '\n\n'.join(['{summary}',
>'{description}',
> ```
>
> Vinod Kone wrote:
> Thanks haosdent for the diff. I committed a patch based on this (and
> attributed it to you).
>
> Michael Lunøe wrote:
> Where do I see this patch, so I know when to re-open this?
It's here
https://github.com/apache/mesos/commit/c93c5009cc0004388b8e248478a2291ff9d0c595.
Not sure what you mean by "re-open this"? Your patch is committed too.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
>
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
>
> haosdent huang wrote:
> I think we could ignore this error message.
>
> Bernd Mathiske wrote:
> I'd rather not ignore the error message. How can there be an out-of-range
> char in HTML and CSS files?
>
> haosdent huang wrote:
> I afraid this may caused by boostrap have some special characters like
> `ok:before{content:"\e013"}`.
>
> Bernd Mathiske wrote:
> This should be an encoding using printable cahrs (<=128) only.
>
> haosdent huang wrote:
> LoL, seems `Michael Lunøe` cause the problem. Need fix the
> apply_reviews.py
>
> haosdent huang wrote:
> Need do changes in apply_reviews.py to support no-ascii commit messages.
> ```
> diff --git a/support/apply-reviews.py b/support/apply-reviews.py
> index ea5e43a..36bfb1e 100755
> --- a/support/apply-reviews.py
> +++ b/support/apply-reviews.py
> @@ -185,7 +185,7 @@ def commit_patch():
>else:
> amend = '-e'
>
> - cmd = 'git commit --author \'{author}\' {_amend} -am \'{message}\''\
> + cmd = u'git commit --author \'{author}\' {_amend} -am \'{message}\''\
> .format(author=quote(data['author']),
> _amend=amend,
> message=quote(data['message']))
> @@ -248,7 +248,7 @@ def reviewboard_data():
>user = url_to_json(reviewboard_user_url(
> review.get('links').get('submitter').get('title'))).get('user')
>
> - author = '{author} <{email}>'.format(author=user.get('fullname'),
> + author = u'{author} <{email}>'.format(author=user.get('fullname'),
> email=user.get('email'))
>message = '\n\n'.join(['{summary}',
>'{description}',
> ```
>
> Vinod Kone wrote:
> Thanks haosdent for the diff. I committed a patch based on this (and
> attributed it to you).
>
> Michael Lunøe wrote:
> Where do I see this patch, so I know when to re-open this?
>
> Vinod Kone wrote:
> It's here
> https://github.com/apache/mesos/commit/c93c5009cc0004388b8e248478a2291ff9d0c595.
>
> Not sure what you mean by "re-open this"? Your patch is committed too.
Oh! Cool!
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff:
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
>
> haosdent huang wrote:
> I think we could ignore this error message.
>
> Bernd Mathiske wrote:
> I'd rather not ignore the error message. How can there be an out-of-range
> char in HTML and CSS files?
>
> haosdent huang wrote:
> I afraid this may caused by boostrap have some special characters like
> `ok:before{content:"\e013"}`.
>
> Bernd Mathiske wrote:
> This should be an encoding using printable cahrs (<=128) only.
>
> haosdent huang wrote:
> LoL, seems `Michael Lunøe` cause the problem. Need fix the
> apply_reviews.py
>
> haosdent huang wrote:
> Need do changes in apply_reviews.py to support no-ascii commit messages.
> ```
> diff --git a/support/apply-reviews.py b/support/apply-reviews.py
> index ea5e43a..36bfb1e 100755
> --- a/support/apply-reviews.py
> +++ b/support/apply-reviews.py
> @@ -185,7 +185,7 @@ def commit_patch():
>else:
> amend = '-e'
>
> - cmd = 'git commit --author \'{author}\' {_amend} -am \'{message}\''\
> + cmd = u'git commit --author \'{author}\' {_amend} -am \'{message}\''\
> .format(author=quote(data['author']),
> _amend=amend,
> message=quote(data['message']))
> @@ -248,7 +248,7 @@ def reviewboard_data():
>user = url_to_json(reviewboard_user_url(
> review.get('links').get('submitter').get('title'))).get('user')
>
> - author = '{author} <{email}>'.format(author=user.get('fullname'),
> + author = u'{author} <{email}>'.format(author=user.get('fullname'),
> email=user.get('email'))
>message = '\n\n'.join(['{summary}',
>'{description}',
> ```
Thanks haosdent for the diff. I committed a patch based on this (and attributed
it to you).
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
> - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
> - 1680 x 1050px screen:
> http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
> - 2880 x 1800px screen:
> http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png
>
> Visual test in
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43072/#review117650 --- Ship it! Ship It! - Vinod Kone On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43072/ > --- > > (Updated Feb. 1, 2016, 11:36 p.m.) > > > Review request for mesos, Bernd Mathiske and Thomas Rampelberg. > > > Bugs: MESOS-2585 > https://issues.apache.org/jira/browse/MESOS-2585 > > > Repository: mesos > > > Description > --- > > The solution to our problem is solved by updating the Bootstrap CSS file, as > container-fluid was introduced later in Bootstrap. > > I have updated to lastest stable release of Bootstrap v3.3.6. Looking through > the change log, the only thing that we are using in the Mesos UI and changed > is the "hide" class (deprecated), so instances of these have been replaced by > its successor ".hidden" class. > > > Diffs > - > > src/webui/master/static/browse.html 6b18056 > src/webui/master/static/css/bootstrap-3.0.3.min.css c547283 > src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION > src/webui/master/static/framework.html 9b28820 > src/webui/master/static/home.html d6cde1e > src/webui/master/static/index.html 25caf53 > src/webui/master/static/slave.html bc46885 > src/webui/master/static/slave_executor.html 9d582d5 > src/webui/master/static/slave_framework.html 96d788f > > Diff: https://reviews.apache.org/r/43072/diff/ > > > Testing > --- > > - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png > - 1680 x 1050px screen: > http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png > - 2880 x 1800px screen: > http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png > > Visual test in latest Chrome, Firefox, Safari and IE. No functional changes > introduced. > > > Thanks, > > Michael Lunøe > >
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
>
> haosdent huang wrote:
> I think we could ignore this error message.
>
> Bernd Mathiske wrote:
> I'd rather not ignore the error message. How can there be an out-of-range
> char in HTML and CSS files?
>
> haosdent huang wrote:
> I afraid this may caused by boostrap have some special characters like
> `ok:before{content:"\e013"}`.
>
> Bernd Mathiske wrote:
> This should be an encoding using printable cahrs (<=128) only.
>
> haosdent huang wrote:
> LoL, seems `Michael Lunøe` cause the problem. Need fix the
> apply_reviews.py
Need do changes in apply_reviews.py to support no-ascii commit messages.
```
diff --git a/support/apply-reviews.py b/support/apply-reviews.py
index ea5e43a..36bfb1e 100755
--- a/support/apply-reviews.py
+++ b/support/apply-reviews.py
@@ -185,7 +185,7 @@ def commit_patch():
else:
amend = '-e'
- cmd = 'git commit --author \'{author}\' {_amend} -am \'{message}\''\
+ cmd = u'git commit --author \'{author}\' {_amend} -am \'{message}\''\
.format(author=quote(data['author']),
_amend=amend,
message=quote(data['message']))
@@ -248,7 +248,7 @@ def reviewboard_data():
user = url_to_json(reviewboard_user_url(
review.get('links').get('submitter').get('title'))).get('user')
- author = '{author} <{email}>'.format(author=user.get('fullname'),
+ author = u'{author} <{email}>'.format(author=user.get('fullname'),
email=user.get('email'))
message = '\n\n'.join(['{summary}',
'{description}',
```
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
> - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
> - 1680 x 1050px screen:
> http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
> - 2880 x 1800px screen:
> http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png
>
> Visual test in latest Chrome, Firefox, Safari and IE. No functional changes
> introduced.
>
>
> Thanks,
>
> Michael Lunøe
>
>
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
>
> haosdent huang wrote:
> I think we could ignore this error message.
>
> Bernd Mathiske wrote:
> I'd rather not ignore the error message. How can there be an out-of-range
> char in HTML and CSS files?
>
> haosdent huang wrote:
> I afraid this may caused by boostrap have some special characters like
> `ok:before{content:"\e013"}`.
>
> Bernd Mathiske wrote:
> This should be an encoding using printable cahrs (<=128) only.
LoL, seems `Michael Lunøe` cause the problem. Need fix the apply_reviews.py
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
> - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
> - 1680 x 1050px screen:
> http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
> - 2880 x 1800px screen:
> http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png
>
> Visual test in latest Chrome, Firefox, Safari and IE. No functional changes
> introduced.
>
>
> Thanks,
>
> Michael Lunøe
>
>
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 1, 2016, 6:45 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
>
> haosdent huang wrote:
> I think we could ignore this error message.
I'd rather not ignore the error message. How can there be an out-of-range char
in HTML and CSS files?
- Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 3:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 3:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
> - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
> - 1680 x 1050px screen:
> http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
> - 2880 x 1800px screen:
> http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png
>
> Visual test in latest Chrome, Firefox, Safari and IE. No functional changes
> introduced.
>
>
> Thanks,
>
> Michael Lunøe
>
>
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
>
> haosdent huang wrote:
> I think we could ignore this error message.
>
> Bernd Mathiske wrote:
> I'd rather not ignore the error message. How can there be an out-of-range
> char in HTML and CSS files?
I afraid this may caused by boostrap have some special characters like
`ok:before{content:"\e013"}`.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
> - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
> - 1680 x 1050px screen:
> http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
> - 2880 x 1800px screen:
> http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png
>
> Visual test in latest Chrome, Firefox, Safari and IE. No functional changes
> introduced.
>
>
> Thanks,
>
> Michael Lunøe
>
>
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 1, 2016, 6:45 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
>
> haosdent huang wrote:
> I think we could ignore this error message.
>
> Bernd Mathiske wrote:
> I'd rather not ignore the error message. How can there be an out-of-range
> char in HTML and CSS files?
>
> haosdent huang wrote:
> I afraid this may caused by boostrap have some special characters like
> `ok:before{content:"\e013"}`.
This should be an encoding using printable cahrs (<=128) only.
- Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 3:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 3:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
> - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
> - 1680 x 1050px screen:
> http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
> - 2880 x 1800px screen:
> http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png
>
> Visual test in latest Chrome, Firefox, Safari and IE. No functional changes
> introduced.
>
>
> Thanks,
>
> Michael Lunøe
>
>
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
Bad patch!
Reviews applied: [43072]
Failed command: ./support/apply-review.sh -n -r 43072
Error:
2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
[226634/226634] -> "43072.patch" [1]
Traceback (most recent call last):
File "support/apply-reviews.py", line 342, in
reviewboard()
File "support/apply-reviews.py", line 321, in reviewboard
apply_review()
File "support/apply-reviews.py", line 139, in apply_review
commit_patch()
File "support/apply-reviews.py", line 180, in commit_patch
data = patch_data()
File "support/apply-reviews.py", line 199, in patch_data
return reviewboard_data()
File "support/apply-reviews.py", line 252, in reviewboard_data
email=user.get('email'))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position
11: ordinal not in range(128)
Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
- Mesos ReviewBot
On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
> - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
> - 1680 x 1050px screen:
> http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
> - 2880 x 1800px screen:
> http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png
>
> Visual test in latest Chrome, Firefox, Safari and IE. No functional changes
> introduced.
>
>
> Thanks,
>
> Michael Lunøe
>
>
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [43072]
> >
> > Failed command: ./support/apply-review.sh -n -r 43072
> >
> > Error:
> > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/
> > [226634/226634] -> "43072.patch" [1]
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 342, in
> > reviewboard()
> > File "support/apply-reviews.py", line 321, in reviewboard
> > apply_review()
> > File "support/apply-reviews.py", line 139, in apply_review
> > commit_patch()
> > File "support/apply-reviews.py", line 180, in commit_patch
> > data = patch_data()
> > File "support/apply-reviews.py", line 199, in patch_data
> > return reviewboard_data()
> > File "support/apply-reviews.py", line 252, in reviewboard_data
> > email=user.get('email'))
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
> > position 11: ordinal not in range(128)
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/11187/console
I think we could ignore this error message.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/#review117347
---
On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43072/
> ---
>
> (Updated Feb. 1, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Thomas Rampelberg.
>
>
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The solution to our problem is solved by updating the Bootstrap CSS file, as
> container-fluid was introduced later in Bootstrap.
>
> I have updated to lastest stable release of Bootstrap v3.3.6. Looking through
> the change log, the only thing that we are using in the Mesos UI and changed
> is the "hide" class (deprecated), so instances of these have been replaced by
> its successor ".hidden" class.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html 6b18056
> src/webui/master/static/css/bootstrap-3.0.3.min.css c547283
> src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION
> src/webui/master/static/framework.html 9b28820
> src/webui/master/static/home.html d6cde1e
> src/webui/master/static/index.html 25caf53
> src/webui/master/static/slave.html bc46885
> src/webui/master/static/slave_executor.html 9d582d5
> src/webui/master/static/slave_framework.html 96d788f
>
> Diff: https://reviews.apache.org/r/43072/diff/
>
>
> Testing
> ---
>
> - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
> - 1680 x 1050px screen:
> http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
> - 2880 x 1800px screen:
> http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png
>
> Visual test in latest Chrome, Firefox, Safari and IE. No functional changes
> introduced.
>
>
> Thanks,
>
> Michael Lunøe
>
>
Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43072/#review117350 --- Ship it! Ship It! - haosdent huang On Feb. 1, 2016, 11:36 p.m., Michael Lunøe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43072/ > --- > > (Updated Feb. 1, 2016, 11:36 p.m.) > > > Review request for mesos, Bernd Mathiske and Thomas Rampelberg. > > > Bugs: MESOS-2585 > https://issues.apache.org/jira/browse/MESOS-2585 > > > Repository: mesos > > > Description > --- > > The solution to our problem is solved by updating the Bootstrap CSS file, as > container-fluid was introduced later in Bootstrap. > > I have updated to lastest stable release of Bootstrap v3.3.6. Looking through > the change log, the only thing that we are using in the Mesos UI and changed > is the "hide" class (deprecated), so instances of these have been replaced by > its successor ".hidden" class. > > > Diffs > - > > src/webui/master/static/browse.html 6b18056 > src/webui/master/static/css/bootstrap-3.0.3.min.css c547283 > src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION > src/webui/master/static/framework.html 9b28820 > src/webui/master/static/home.html d6cde1e > src/webui/master/static/index.html 25caf53 > src/webui/master/static/slave.html bc46885 > src/webui/master/static/slave_executor.html 9d582d5 > src/webui/master/static/slave_framework.html 96d788f > > Diff: https://reviews.apache.org/r/43072/diff/ > > > Testing > --- > > - Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png > - 1680 x 1050px screen: > http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png > - 2880 x 1800px screen: > http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png > > Visual test in latest Chrome, Firefox, Safari and IE. No functional changes > introduced. > > > Thanks, > > Michael Lunøe > >
