Re: Review Request 43848: Used `size_t` to track number of frameworks per role.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43848/#review120334 --- Ship it! Thanks! Looks like there are a few other spots in the allocation code: https://github.com/apache/mesos/blob/0.27.1/src/master/allocator/mesos/hierarchical.cpp#L151 (notice the non-negative CHECK) https://github.com/apache/mesos/blob/0.27.1/src/master/allocator/sorter/sorter.hpp#L119-L121 - Ben Mahler On Feb. 22, 2016, 7:54 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43848/ > --- > > (Updated Feb. 22, 2016, 7:54 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Per informal project style, we prefer using unsigned types to > represent non-negative quantities. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > 0d39d3f3b5f4ff7f62f9de7200d062845c71818a > > Diff: https://reviews.apache.org/r/43848/diff/ > > > Testing > --- > > make check on OSX > > Compilation on Linux with GCC 5.3 > > > Thanks, > > Neil Conway > >
Re: Review Request 43848: Used `size_t` to track number of frameworks per role.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43848/#review120326 --- Patch looks great! Reviews applied: [43848] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 22, 2016, 7:54 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43848/ > --- > > (Updated Feb. 22, 2016, 7:54 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Per informal project style, we prefer using unsigned types to > represent non-negative quantities. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > 0d39d3f3b5f4ff7f62f9de7200d062845c71818a > > Diff: https://reviews.apache.org/r/43848/diff/ > > > Testing > --- > > make check on OSX > > Compilation on Linux with GCC 5.3 > > > Thanks, > > Neil Conway > >
Re: Review Request 43848: Used `size_t` to track number of frameworks per role.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43848/#review120294 --- Ship it! Ship It! - Klaus Ma On Feb. 23, 2016, 3:54 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43848/ > --- > > (Updated Feb. 23, 2016, 3:54 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Per informal project style, we prefer using unsigned types to > represent non-negative quantities. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > 0d39d3f3b5f4ff7f62f9de7200d062845c71818a > > Diff: https://reviews.apache.org/r/43848/diff/ > > > Testing > --- > > make check on OSX > > Compilation on Linux with GCC 5.3 > > > Thanks, > > Neil Conway > >
