Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review125782 --- Fix it, then Ship it! Thanks! Kevin and I went over this and

Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-21 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/ --- (Updated March 21, 2016, 6:06 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-20 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124093 --- For reference, Ahishek and I talked offline, and he modified his

Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-20 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124096 --- src/linux/cgroups.hpp (line 645)

Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124265 --- src/linux/cgroups.hpp (line 629)

Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/ --- (Updated March 18, 2016, 9:41 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124374 --- I ran the review by Ben again and sat with him to rework it to