Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Guangya Liu 


> On 四月 14, 2016, 10:55 p.m., Jie Yu wrote:
> > docs/configuration.md, line 1411
> > 
> >
> > It's a directory or a file? Instead of doing that, can we just assume 
> > dvdcli is in 'PATH' and add a check in DockerVolumeDriverClient::create?

OK, will try to use `os::which` to handle this. There is a JIRA tracing it: 
https://issues.apache.org/jira/browse/MESOS-4576 , will try to upload a patch 
for it.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/#review129022
---


On 四月 14, 2016, 6:06 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45326/
> ---
> 
> (Updated 四月 14, 2016, 6:06 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5084
> https://issues.apache.org/jira/browse/MESOS-5084
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag dvdcli_dir for specify dvdcli path.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md ce51f26f0584eeecb5c96e39a5bcc21f5906a29c 
>   src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a 
>   src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
> 
> Diff: https://reviews.apache.org/r/45326/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/#review129022
---




docs/configuration.md (line 1411)


It's a directory or a file? Instead of doing that, can we just assume 
dvdcli is in 'PATH' and add a check in DockerVolumeDriverClient::create?


- Jie Yu


On April 14, 2016, 6:06 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45326/
> ---
> 
> (Updated April 14, 2016, 6:06 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5084
> https://issues.apache.org/jira/browse/MESOS-5084
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag dvdcli_dir for specify dvdcli path.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md ce51f26f0584eeecb5c96e39a5bcc21f5906a29c 
>   src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a 
>   src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
> 
> Diff: https://reviews.apache.org/r/45326/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/#review128941
---




src/slave/flags.cpp (line 803)


Just leave a concern here:

Do we always have dvdcli installed in `/usr/bin` for all os (e.g., centos)? 
any special case?


- Gilbert Song


On April 13, 2016, 11:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45326/
> ---
> 
> (Updated April 13, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5084
> https://issues.apache.org/jira/browse/MESOS-5084
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag dvdcli_dir for specify dvdcli path.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md ce51f26f0584eeecb5c96e39a5bcc21f5906a29c 
>   src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a 
>   src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
> 
> Diff: https://reviews.apache.org/r/45326/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/
---

(Updated 四月 14, 2016, 6:06 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5084
https://issues.apache.org/jira/browse/MESOS-5084


Repository: mesos


Description
---

Added agent flag dvdcli_dir for specify dvdcli path.


Diffs (updated)
-

  docs/configuration.md ce51f26f0584eeecb5c96e39a5bcc21f5906a29c 
  src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a 
  src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 

Diff: https://reviews.apache.org/r/45326/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-13 Thread Guangya Liu 


> On 四月 13, 2016, 9:01 p.m., James DeFelice wrote:
> > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 64
> > 
> >
> > should we verify that the dvdcli binary actually exists here (and if 
> > not generate an error)?

Yes, will fix this in https://reviews.apache.org/r/46180


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/#review128743
---


On 四月 14, 2016, 4:57 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45326/
> ---
> 
> (Updated 四月 14, 2016, 4:57 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5084
> https://issues.apache.org/jira/browse/MESOS-5084
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag dvdcli_dir for specify dvdcli path.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md ce51f26f0584eeecb5c96e39a5bcc21f5906a29c 
>   src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a 
>   src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
> 
> Diff: https://reviews.apache.org/r/45326/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-13 Thread James DeFelice 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/#review128743
---




src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (line 64)


should we verify that the dvdcli binary actually exists here (and if not 
generate an error)?


- James DeFelice


On April 2, 2016, 3:54 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45326/
> ---
> 
> (Updated April 2, 2016, 3:54 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag dvdcli_dir for specify dvdcli path.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   src/slave/constants.hpp 449c8cd9f43f71b4612023eb463969e9db0bc960 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
>   src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
> 
> Diff: https://reviews.apache.org/r/45326/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>