Re: Review Request 45345: Added a python module to mock a CNI plugin and IPAM.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45345/#review141576 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On March 27, 2016, 2:52 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45345/ > --- > > (Updated March 27, 2016, 2:52 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-4763 > https://issues.apache.org/jira/browse/MESOS-4763 > > > Repository: mesos > > > Description > --- > > Added a python module to mock a CNI plugin and IPAM. > > > Diffs > - > > src/tests/containerizer/network/cni/cniplugin.py PRE-CREATION > src/tests/containerizer/network/cni/cniplugin_test.conf PRE-CREATION > src/tests/containerizer/network/cni/cniplugin_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/45345/diff/ > > > Testing > --- > > Ran a test configuration against the mock plugin to make sure that the output > is similar to that returned by a real CNI plugin. > > > Thanks, > > Avinash sridharan > >
Re: Review Request 45345: Added a python module to mock a CNI plugin and IPAM.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45345/#review125567 --- Patch looks great! Reviews applied: [45345] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 27, 2016, 2:52 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45345/ > --- > > (Updated March 27, 2016, 2:52 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-4763 > https://issues.apache.org/jira/browse/MESOS-4763 > > > Repository: mesos > > > Description > --- > > Added a python module to mock a CNI plugin and IPAM. > > > Diffs > - > > src/tests/containerizer/network/cni/cniplugin.py PRE-CREATION > src/tests/containerizer/network/cni/cniplugin_test.conf PRE-CREATION > src/tests/containerizer/network/cni/cniplugin_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/45345/diff/ > > > Testing > --- > > Ran a test configuration against the mock plugin to make sure that the output > is similar to that returned by a real CNI plugin. > > > Thanks, > > Avinash sridharan > >
Re: Review Request 45345: Added a python module to mock a CNI plugin and IPAM.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45345/ --- (Updated March 27, 2016, 2:52 p.m.) Review request for mesos, Jie Yu and Qian Zhang. Changes --- Fixed a typo in the comments. Bugs: MESOS-4763 https://issues.apache.org/jira/browse/MESOS-4763 Repository: mesos Description --- Added a python module to mock a CNI plugin and IPAM. Diffs (updated) - src/tests/containerizer/network/cni/cniplugin.py PRE-CREATION src/tests/containerizer/network/cni/cniplugin_test.conf PRE-CREATION src/tests/containerizer/network/cni/cniplugin_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/45345/diff/ Testing --- Ran a test configuration against the mock plugin to make sure that the output is similar to that returned by a real CNI plugin. Thanks, Avinash sridharan
