Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/#review142097
---



Note: I replaced `NULL` with `nullptr` prior to committing.

- Joseph Wu


On June 2, 2016, 1:31 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45995/
> ---
> 
> (Updated June 2, 2016, 1:31 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed memory leak of `Route` in `finalize()` in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> be120fb85583d438401c24a57dac803be3b5e5d2 
> 
> Diff: https://reviews.apache.org/r/45995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/
---

(Updated June 2, 2016, 8:31 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Rebase.


Bugs: MESOS-5144
https://issues.apache.org/jira/browse/MESOS-5144


Repository: mesos


Description
---

Fixed memory leak of `Route` in `finalize()` in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp be120fb85583d438401c24a57dac803be3b5e5d2 

Diff: https://reviews.apache.org/r/45995/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/#review132130
---


Ship it!




Ship It!

- haosdent huang


On May 3, 2016, 9:40 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45995/
> ---
> 
> (Updated May 3, 2016, 9:40 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed memory leak of `Route` in `finalize()` in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/45995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/#review131788
---


Ship it!




Ship It!

- Zhiwei Chen


On May 3, 2016, 5:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45995/
> ---
> 
> (Updated May 3, 2016, 5:40 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed memory leak of `Route` in `finalize()` in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/45995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/
---

(Updated May 3, 2016, 9:40 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Fix style issue per haosdent


Bugs: MESOS-5144
https://issues.apache.org/jira/browse/MESOS-5144


Repository: mesos


Description
---

Fixed memory leak of `Route` in `finalize()` in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/45995/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

[Neil Conway]

> On May 2, 2016, 5:53 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/src/process.cpp, line 1007
> > 
> >
> > I am no sure if use `processes_route` style to keep consistent with 
> > `process_manager`.

Good catch!


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/#review131340
---


On April 11, 2016, 1:39 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45995/
> ---
> 
> (Updated April 11, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed memory leak of `Route` in `finalize()` in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/45995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/#review131340
---




3rdparty/libprocess/src/process.cpp (line 1007)


I am no sure if use `processes_route` style to keep consistent with 
`process_manager`.


- haosdent huang


On April 11, 2016, 1:39 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45995/
> ---
> 
> (Updated April 11, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed memory leak of `Route` in `finalize()` in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/45995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/#review129106
---


Ship it!




Ship It!

- Alexander Rojas


On April 11, 2016, 3:39 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45995/
> ---
> 
> (Updated April 11, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed memory leak of `Route` in `finalize()` in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/45995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/#review128955
---


Ship it!




Ship It!

- Joseph Wu


On April 10, 2016, 6:39 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45995/
> ---
> 
> (Updated April 10, 2016, 6:39 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed memory leak of `Route` in `finalize()` in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/45995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>