Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/#review135162 --- Ship it! Ship It! - Jie Yu On May 9, 2016, 10:39 p.m.,

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-20 Thread Gilbert Song
> On May 20, 2016, 4:14 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1189 > > > > > > Seems like the reporter in MESOS-5197 is requesting `LOG(INFO)`. Sorry > > for previous

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/ --- (Updated 五月 9, 2016, 10:39 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/#review132069 --- Patch looks great! Reviews applied: [46874] Passed command:

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/ --- (Updated May 6, 2016, 5:59 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/#review131968 --- @Yu Jie and @Gilbert, any comments on the message? My thinking is

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-04 Thread Guangya Liu
> On 五月 3, 2016, 10:36 p.m., Gilbert Song wrote: > > It seems to me that we have `Starting container..` in launch() and `cloning > > child..` in fork(). Yes, but what I want to hightlight is the flags that we used to start `mesos-containerizer`, so just using `lauch mesos-containerizer`, any

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/#review131575 --- It seems to me that we have `Starting container..` in launch()

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/#review131261 --- Patch looks great! Reviews applied: [46874] Passed command:

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/ --- (Updated 五月 1, 2016, 6:24 a.m.) Review request for mesos, Gilbert Song and Jie