Re: Review Request 47492: Windows: Updated the containerizer name to `mesos-containerizer.exe`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47492/
---

(Updated May 19, 2016, 10:26 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van Remoortere, 
and Michael Park.


Repository: mesos


Description
---

Windows: Updated the containerizer name to `mesos-containerizer.exe`.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 

Diff: https://reviews.apache.org/r/47492/diff/


Testing
---

Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 47492: Windows: Updated the containerizer name to `mesos-containerizer.exe`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47492/#review133695
---



Patch looks great!

Reviews applied: [47492]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 17, 2016, 9:33 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47492/
> ---
> 
> (Updated May 17, 2016, 9:33 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Updated the containerizer name to `mesos-containerizer.exe`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
> 
> Diff: https://reviews.apache.org/r/47492/diff/
> 
> 
> Testing
> ---
> 
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 47492: Windows: Updated the containerizer name to `mesos-containerizer.exe`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47492/#review133638
---


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.cpp (lines 132 - 136)


Can we flip the order here? As in use `ifndef`.


- Joris Van Remoortere


On May 17, 2016, 9:33 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47492/
> ---
> 
> (Updated May 17, 2016, 9:33 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Updated the containerizer name to `mesos-containerizer.exe`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
> 
> Diff: https://reviews.apache.org/r/47492/diff/
> 
> 
> Testing
> ---
> 
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>