Re: Review Request 64450: Update docs to mention new flag.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64450/#review194241
---



PASS: Mesos patch 64450 was successfully built and tested.

Reviews applied: `['64450']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64450

- Mesos Reviewbot Windows


On Dec. 20, 2017, 2:11 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64450/
> ---
> 
> (Updated Dec. 20, 2017, 2:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docs to mention new  flag.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 8b3d3642c50a60b6ce0f9d27031c2077254473de 
>   docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36 
>   docs/configuration/agent.md d629912e391cebd88c9d0daeabc3bbf436344e95 
>   src/slave/flags.cpp d4b95b7542733b22299bc19235cf99220534c022 
> 
> 
> Diff: https://reviews.apache.org/r/64450/diff/2/
> 
> 
> Testing
> ---
> 
> One pass of proof-reading.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 64450: Update docs to mention new flag.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64450/
---

(Updated Dec. 20, 2017, 2:11 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Bugs: MESOS-1739
https://issues.apache.org/jira/browse/MESOS-1739


Repository: mesos


Description
---

Update docs to mention new  flag.


Diffs
-

  CHANGELOG 8b3d3642c50a60b6ce0f9d27031c2077254473de 
  docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36 
  docs/configuration/agent.md d629912e391cebd88c9d0daeabc3bbf436344e95 
  src/slave/flags.cpp d4b95b7542733b22299bc19235cf99220534c022 


Diff: https://reviews.apache.org/r/64450/diff/2/


Testing
---

One pass of proof-reading.


Thanks,

Benno Evers

Re: Review Request 64450: Update docs to mention new flag.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64450/#review194239
---


Fix it, then Ship it!




I'll fix the last outstanding issue and commit it for you.


docs/agent-recovery.md
Lines 72-73 (patched)


Indentation


- Alexander Rukletsov


On Dec. 20, 2017, 1:26 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64450/
> ---
> 
> (Updated Dec. 20, 2017, 1:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docs to mention new  flag.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 8b3d3642c50a60b6ce0f9d27031c2077254473de 
>   docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36 
>   docs/configuration/agent.md d629912e391cebd88c9d0daeabc3bbf436344e95 
>   src/slave/flags.cpp d4b95b7542733b22299bc19235cf99220534c022 
> 
> 
> Diff: https://reviews.apache.org/r/64450/diff/2/
> 
> 
> Testing
> ---
> 
> One pass of proof-reading.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 64450: Update docs to mention new flag.

[Benno Evers]

> On Dec. 20, 2017, 11:27 a.m., Alexander Rukletsov wrote:
> > docs/agent-recovery.md
> > Lines 20-22 (original), 21-23 (patched)
> > 
> >
> > Why have you killed this paragraph? Maybe somehow combine it with the 
> > previous one?

It felt redundant, but I restored it now.


> On Dec. 20, 2017, 11:27 a.m., Alexander Rukletsov wrote:
> > docs/agent-recovery.md
> > Line 26 (original), 27 (patched)
> > 
> >
> > s/refuse/will refuse

Looks like both are correct: 
https://english.stackexchange.com/questions/63081/repeating-to-and-will-in-enumerations-of-verbs

I still went ahead and changed it.


> On Dec. 20, 2017, 11:27 a.m., Alexander Rukletsov wrote:
> > docs/agent-recovery.md
> > Lines 51-57 (original), 55-61 (patched)
> > 
> >
> > Any reason to remove this section in this RR?

It's a bit confusing to say that the `recover` option affects the slave 
recovery behaviour when it has to be set to `reconnect` in order to be able to 
even talk about recovery (since setting it to `cleanup` will just turn the 
`mesos-agent` into some cleanup binary that never registers with the master or 
recovers anything)


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64450/#review194226
---


On Dec. 20, 2017, 1:26 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64450/
> ---
> 
> (Updated Dec. 20, 2017, 1:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docs to mention new  flag.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 8b3d3642c50a60b6ce0f9d27031c2077254473de 
>   docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36 
>   docs/configuration/agent.md d629912e391cebd88c9d0daeabc3bbf436344e95 
>   src/slave/flags.cpp d4b95b7542733b22299bc19235cf99220534c022 
> 
> 
> Diff: https://reviews.apache.org/r/64450/diff/2/
> 
> 
> Testing
> ---
> 
> One pass of proof-reading.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 64450: Update docs to mention new flag.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64450/
---

(Updated Dec. 20, 2017, 1:26 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Summary (updated)
-

Update docs to mention new  flag.


Repository: mesos


Description
---

Update docs to mention new  flag.


Diffs (updated)
-

  CHANGELOG 8b3d3642c50a60b6ce0f9d27031c2077254473de 
  docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36 
  docs/configuration/agent.md d629912e391cebd88c9d0daeabc3bbf436344e95 
  src/slave/flags.cpp d4b95b7542733b22299bc19235cf99220534c022 


Diff: https://reviews.apache.org/r/64450/diff/2/

Changes: https://reviews.apache.org/r/64450/diff/1-2/


Testing
---

One pass of proof-reading.


Thanks,

Benno Evers