Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

2018-01-22 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/
---

(Updated Jan. 22, 2018, 4:23 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer, 
Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann, Ilya Pronin, Jie 
Yu, James Peach, Kapil Arya, Joseph Wu, Kevin Klues, Neil Conway, Qian Zhang, 
Till Toenshoff, Vinod Kone, Jiang Yan Xu, and Zhitao Li.


Repository: mesos


Description
---

Updated the CHANGELOG for 1.5.0 release.


Diffs (updated)
-

  CHANGELOG 078c5d64100d81ce84dbdff4055cdda465e19011 


Diff: https://reviews.apache.org/r/65203/diff/3/

Changes: https://reviews.apache.org/r/65203/diff/2-3/


Testing
---

N/A.


Thanks,

Gilbert Song

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

2018-01-22 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/#review195889
---


Ship it!




Ship It!

- Alexander Rukletsov


On Jan. 20, 2018, 2:01 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65203/
> ---
> 
> (Updated Jan. 20, 2018, 2:01 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer, 
> Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann, Ilya Pronin, Jie 
> Yu, James Peach, Kapil Arya, Joseph Wu, Kevin Klues, Neil Conway, Qian Zhang, 
> Till Toenshoff, Vinod Kone, Jiang Yan Xu, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the CHANGELOG for 1.5.0 release.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 078c5d64100d81ce84dbdff4055cdda465e19011 
> 
> 
> Diff: https://reviews.apache.org/r/65203/diff/2/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

2018-01-19 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/
---

(Updated Jan. 19, 2018, 6:01 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer, 
Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann, Ilya Pronin, Jie 
Yu, James Peach, Kapil Arya, Joseph Wu, Kevin Klues, Neil Conway, Qian Zhang, 
Till Toenshoff, Vinod Kone, Jiang Yan Xu, and Zhitao Li.


Repository: mesos


Description
---

Updated the CHANGELOG for 1.5.0 release.


Diffs (updated)
-

  CHANGELOG 078c5d64100d81ce84dbdff4055cdda465e19011 


Diff: https://reviews.apache.org/r/65203/diff/2/

Changes: https://reviews.apache.org/r/65203/diff/1-2/


Testing
---

N/A.


Thanks,

Gilbert Song

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

2018-01-17 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/#review195684
---



PASS: Mesos patch 65203 was successfully built and tested.

Reviews applied: `['65203']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65203

- Mesos Reviewbot Windows


On Jan. 18, 2018, 12:21 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65203/
> ---
> 
> (Updated Jan. 18, 2018, 12:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer, 
> Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann, Ilya Pronin, Jie 
> Yu, James Peach, Kapil Arya, Joseph Wu, Kevin Klues, Neil Conway, Qian Zhang, 
> Till Toenshoff, Vinod Kone, Jiang Yan Xu, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the CHANGELOG for 1.5.0 release.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 078c5d64100d81ce84dbdff4055cdda465e19011 
> 
> 
> Diff: https://reviews.apache.org/r/65203/diff/1/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

2018-01-17 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/#review195676
---


Fix it, then Ship it!





CHANGELOG
Line 17 (original), 17 (patched)


Add a blank line above like you did above?



CHANGELOG
Line 60 (original), 130 (patched)


I'd move Feature Graduation up before unresolved critical issues



CHANGELOG
Lines 135 (patched)


I'd combine all capabilities related tickets into one bullet.

This should be similar to the first section that, instead of copying the 
ticket summary, we should write full sentenses to explain that that feature is.



CHANGELOG
Lines 142 (patched)


See my comment above, combine with other capabilities related tickets into 
one bullet.


- Jie Yu


On Jan. 18, 2018, 12:21 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65203/
> ---
> 
> (Updated Jan. 18, 2018, 12:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer, 
> Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann, Ilya Pronin, Jie 
> Yu, James Peach, Kapil Arya, Joseph Wu, Kevin Klues, Neil Conway, Qian Zhang, 
> Till Toenshoff, Vinod Kone, Jiang Yan Xu, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the CHANGELOG for 1.5.0 release.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 078c5d64100d81ce84dbdff4055cdda465e19011 
> 
> 
> Diff: https://reviews.apache.org/r/65203/diff/1/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

2018-01-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/#review195672
---


Fix it, then Ship it!




LGTM


CHANGELOG
Line 21 (original), 21 (patched)


s/Support/support for/


- Vinod Kone


On Jan. 18, 2018, 12:21 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65203/
> ---
> 
> (Updated Jan. 18, 2018, 12:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer, 
> Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann, Ilya Pronin, Jie 
> Yu, James Peach, Kapil Arya, Joseph Wu, Kevin Klues, Neil Conway, Qian Zhang, 
> Till Toenshoff, Vinod Kone, Jiang Yan Xu, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the CHANGELOG for 1.5.0 release.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 078c5d64100d81ce84dbdff4055cdda465e19011 
> 
> 
> Diff: https://reviews.apache.org/r/65203/diff/1/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

2018-01-17 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/#review195671
---


Fix it, then Ship it!





CHANGELOG
Line 14 (original), 14 (patched)


"for the Container Storage Interface"



CHANGELOG
Line 23 (original), 23 (patched)


"is built into libprocess"


- James Peach


On Jan. 18, 2018, 12:21 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65203/
> ---
> 
> (Updated Jan. 18, 2018, 12:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer, 
> Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann, Ilya Pronin, Jie 
> Yu, James Peach, Kapil Arya, Joseph Wu, Kevin Klues, Neil Conway, Qian Zhang, 
> Till Toenshoff, Vinod Kone, Jiang Yan Xu, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the CHANGELOG for 1.5.0 release.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 078c5d64100d81ce84dbdff4055cdda465e19011 
> 
> 
> Diff: https://reviews.apache.org/r/65203/diff/1/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

2018-01-17 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/#review195673
---



lgtm


CHANGELOG
Lines 134 (patched)


This one should be reworded; s/Investigate supporting /Added support for/


- Till Toenshoff


On Jan. 18, 2018, 12:21 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65203/
> ---
> 
> (Updated Jan. 18, 2018, 12:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer, 
> Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann, Ilya Pronin, Jie 
> Yu, James Peach, Kapil Arya, Joseph Wu, Kevin Klues, Neil Conway, Qian Zhang, 
> Till Toenshoff, Vinod Kone, Jiang Yan Xu, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the CHANGELOG for 1.5.0 release.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 078c5d64100d81ce84dbdff4055cdda465e19011 
> 
> 
> Diff: https://reviews.apache.org/r/65203/diff/1/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>