> On April 19, 2016, 3:37 p.m., Neil Conway wrote:
> > Can we update the docs to describe this behavior? e.g., add a note to
> > https://mesos.apache.org/documentation/latest/endpoints/ describing the
> > redirect behavior -- I suppose it is worth adding a note to every master
> > endpoint's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review129545
---
Can we update the docs to describe this behavior? e.g., add a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review129471
---
Patch looks great!
Reviews applied: [34646]
Passed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/
---
(Updated April 19, 2016, 1:55 a.m.)
Review request for mesos, Adam B, Anand
> On April 18, 2016, 9:18 p.m., Vinod Kone wrote:
> > LGTM overall. Just wondering if this is considered a backwards incompatible
> > change for operators/tools that did not expect a redirect previously. Can
> > you send an email to the dev/user list if this is an OK change to make
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review129436
---
LGTM overall. Just wondering if this is considered a backwards
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/
---
(Updated April 16, 2016, 5:01 p.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/
---
(Updated July 3, 2015, 2:24 p.m.)
Review request for mesos and Adam B.
Bugs:
On June 30, 2015, 3:37 a.m., Adam B wrote:
src/master/http.cpp, line 424
https://reviews.apache.org/r/34646/diff/5/?file=975677#file975677line424
Is there a way you could reuse all or part of Http::redirect()? Seems
like a lot of copy/paste.
I add a condition in redirect method
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/
---
(Updated July 2, 2015, 11:24 a.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/
---
(Updated July 2, 2015, 11:22 a.m.)
Review request for mesos and Adam B.
On June 1, 2015, 1:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
On June 1, 2015, 8:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
On June 1, 2015, 8:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
On June 1, 2015, 1:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
On June 30, 2015, 6:48 p.m., Vinod Kone wrote:
This is an API change! Before embarking on this change, it's prudent to get
feedback from the community on acceptable semantics (e.g., what do popular
metric collectors do if they encounter 302 redirect? do they ignore the
value or
On June 30, 2015, 11:48 a.m., Vinod Kone wrote:
This is an API change! Before embarking on this change, it's prudent to get
feedback from the community on acceptable semantics (e.g., what do popular
metric collectors do if they encounter 302 redirect? do they ignore the
value or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review89945
---
This is an API change! Before embarking on this change, it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review89799
---
Looks great, thanks! I still wonder if we can remove some of the
On June 1, 2015, 8:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/
---
(Updated June 1, 2015, 6:35 a.m.)
Review request for mesos and Adam B.
Bugs:
On May 28, 2015, 7:51 a.m., Adam B wrote:
src/master/http.cpp, line 1044
https://reviews.apache.org/r/34646/diff/1/?file=971274#file971274line1044
The JIRA suggests that this case should not return OK (200), unless it
queries the active master to return the actual tasks list.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review85951
---
Patch looks great!
Reviews applied: [34646]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/
---
(Updated June 1, 2015, 3:07 p.m.)
Review request for mesos and Adam B.
Bugs:
On June 1, 2015, 8:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
@adam-mesos, I have a newbie problem. In the
On June 1, 2015, 1:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
On June 1, 2015, 8:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
27 matches
Mail list logo
