Re: Review Request 52095: Add the new flag for executor launching with different user.

2016-09-21 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52095/#review149879
---




src/slave/container_loggers/lib_logrotate.hpp (line 89)


We recently removed this static cast.  Old changes like this sometimes 
appear when you have a development branch that is out-of-sync with your master 
branch.

The recommended steps are to:
1) Checkout master and pull the latest changes.
2) Checkout your development branch and rebase on master.
3) Post the review again.



src/slave/container_loggers/lib_logrotate.hpp (lines 160 - 163)


This set of flags defines the module's configuration.  We only need to 
change the user in the module's companion executable though, so you can remove 
this flag.

Keep it in `logrotate.hpp` though.


- Joseph Wu


On Sept. 20, 2016, 8:54 p.m., Sivaram Kannan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52095/
> ---
> 
> (Updated Sept. 20, 2016, 8:54 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
> https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the new flag for executor launching with different user.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp 
> a8653d716a898f03cce83f7b88b666dc46c0ea90 
>   src/slave/container_loggers/logrotate.hpp 
> f906a167f8897385af5f54e1e77cb790121a 
> 
> Diff: https://reviews.apache.org/r/52095/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>

Re: Review Request 52095: Add the new flag for executor launching with different user.

2016-09-20 Thread Sivaram Kannan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52095/
---

(Updated Sept. 21, 2016, 3:54 a.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Add the new flag for executor launching with different user.


Diffs (updated)
-

  src/slave/container_loggers/lib_logrotate.hpp 
a8653d716a898f03cce83f7b88b666dc46c0ea90 
  src/slave/container_loggers/logrotate.hpp 
f906a167f8897385af5f54e1e77cb790121a 

Diff: https://reviews.apache.org/r/52095/diff/


Testing
---


Thanks,

Sivaram Kannan

Re: Review Request 52095: Add the new flag for executor launching with different user.

2016-09-20 Thread Sivaram Kannan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52095/
---

(Updated Sept. 21, 2016, 1:02 a.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Add the new flag for executor launching with different user.


Diffs
-

  src/slave/container_loggers/lib_logrotate.hpp 
a8653d716a898f03cce83f7b88b666dc46c0ea90 
  src/slave/container_loggers/logrotate.hpp 
f906a167f8897385af5f54e1e77cb790121a 

Diff: https://reviews.apache.org/r/52095/diff/


Testing
---


Thanks,

Sivaram Kannan