Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/ --- (Updated July 12, 2018, 8:13 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/#review206000 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 1994

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/ --- (Updated July 12, 2018, 4:38 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

> On July 11, 2018, 12:15 p.m., Jan Schlicht wrote: > > include/mesos/mesos.proto > > Lines 2006 (patched) > > > > > > s/target/disk/ Somehow my response to this was dropped :( I originally used `disk` here but

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

> On July 11, 2018, 12:47 p.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 1927-1929 (original), 1927-1932 (patched) > > > > > > We don't seem to document removed proto definitions, maybe we

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

> On July 11, 2018, 12:15 p.m., Jan Schlicht wrote: > > include/mesos/mesos.proto > > Lines 1991 (patched) > > > > > > Let's not say "convert" here, otherwise we could use a single > > `ConvertVolume` operation

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/#review205966 --- include/mesos/mesos.proto Lines 1927-1929 (original), 1927-1932

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/#review205965 --- include/mesos/mesos.proto Lines 1991 (patched)

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/ --- (Updated July 10, 2018, 3:10 a.m.) Review request for mesos, Benjamin Bannier,