Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/#review91928 --- Ship it! src/tests/scheduler_event_call_tests.cpp (line 91) https://reviews.apache.org/r/36494/#comment145658 Can you add a comment here saying that you are simulating master sending the event? - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/ --- (Updated July 15, 2015, 1:47 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2910 https://issues.apache.org/jira/browse/MESOS-2910 Repository: mesos Description --- See above. Diffs - src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f src/tests/scheduler_event_call_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36494/diff/ Testing --- Added a test. Thanks, Ben Mahler
Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.
On July 16, 2015, 6:20 p.m., Vinod Kone wrote: src/tests/scheduler_event_call_tests.cpp, line 91 https://reviews.apache.org/r/36494/diff/1/?file=1011987#file1011987line91 Can you add a comment here saying that you are simulating master sending the event? Hm.. I'll have to scatter this comment across all the tests I've added in this chain, I'll add a comment at the 'SchedulerDriverEventTest' level instead since all the tests post events manually. Good? - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/#review91928 --- On July 15, 2015, 1:47 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/ --- (Updated July 15, 2015, 1:47 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2910 https://issues.apache.org/jira/browse/MESOS-2910 Repository: mesos Description --- See above. Diffs - src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f src/tests/scheduler_event_call_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36494/diff/ Testing --- Added a test. Thanks, Ben Mahler
Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.
On July 16, 2015, 6:20 p.m., Vinod Kone wrote: src/tests/scheduler_event_call_tests.cpp, line 91 https://reviews.apache.org/r/36494/diff/1/?file=1011987#file1011987line91 Can you add a comment here saying that you are simulating master sending the event? Ben Mahler wrote: Hm.. I'll have to scatter this comment across all the tests I've added in this chain, I'll add a comment at the 'SchedulerDriverEventTest' level instead since all the tests post events manually. Good? sg. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/#review91928 --- On July 15, 2015, 1:47 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/ --- (Updated July 15, 2015, 1:47 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2910 https://issues.apache.org/jira/browse/MESOS-2910 Repository: mesos Description --- See above. Diffs - src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f src/tests/scheduler_event_call_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36494/diff/ Testing --- Added a test. Thanks, Ben Mahler
Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/#review91819 --- src/sched/sched.cpp (lines 489 - 492) https://reviews.apache.org/r/36494/#comment145458 instead of calling into frameworkMessage() here can you have frameworkMessage() call into a new message(const Event event) method? this is how we did it in the master and i think it will make deprecating old message handlers easy. - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/ --- (Updated July 15, 2015, 1:47 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2910 https://issues.apache.org/jira/browse/MESOS-2910 Repository: mesos Description --- See above. Diffs - src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f src/tests/scheduler_event_call_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36494/diff/ Testing --- Added a test. Thanks, Ben Mahler
Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2910 https://issues.apache.org/jira/browse/MESOS-2910 Repository: mesos Description --- See above. Diffs - src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f src/tests/scheduler_event_call_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36494/diff/ Testing --- Added a test. Thanks, Ben Mahler
