Re: Review Request 36807: [WIP] Adding a test for MasterInfo

2015-07-28 Thread Marco Massenzio


 On July 28, 2015, 9:12 p.m., Vinod Kone wrote:
  Found the bug. https://issues.apache.org/jira/browse/MESOS-3168 
  
  I'll prep a fix for it to unblock you.

Sweet! Thanks!


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93347
---


On July 25, 2015, 12:49 a.m., Marco Massenzio wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36807/
 ---
 
 (Updated July 25, 2015, 12:49 a.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-2736
 https://issues.apache.org/jira/browse/MESOS-2736
 
 
 Repository: mesos
 
 
 Description
 ---
 
 We want to test that when the master gets initialized, the
 MasterInfo that it creates (and gets ultimately serialized to
 ZooKeeper) has the correct information in its Address field.
 
 Currently, the test hangs when run in after another
 MasterZooKeeperTest, due to some issues around the recovery.
 
 Jira: MESOS-2736
 
 
 Diffs
 -
 
   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
 
 Diff: https://reviews.apache.org/r/36807/diff/
 
 
 Testing
 ---
 
 make check
 (the test by itself passes - but it will hang indefinitely when run after the 
 other MasterZookeeperTest)
 
 
 Thanks,
 
 Marco Massenzio
 




Re: Review Request 36807: [WIP] Adding a test for MasterInfo

2015-07-28 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93347
---


Found the bug. https://issues.apache.org/jira/browse/MESOS-3168 

I'll prep a fix for it to unblock you.

- Vinod Kone


On July 25, 2015, 12:49 a.m., Marco Massenzio wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36807/
 ---
 
 (Updated July 25, 2015, 12:49 a.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-2736
 https://issues.apache.org/jira/browse/MESOS-2736
 
 
 Repository: mesos
 
 
 Description
 ---
 
 We want to test that when the master gets initialized, the
 MasterInfo that it creates (and gets ultimately serialized to
 ZooKeeper) has the correct information in its Address field.
 
 Currently, the test hangs when run in after another
 MasterZooKeeperTest, due to some issues around the recovery.
 
 Jira: MESOS-2736
 
 
 Diffs
 -
 
   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
 
 Diff: https://reviews.apache.org/r/36807/diff/
 
 
 Testing
 ---
 
 make check
 (the test by itself passes - but it will hang indefinitely when run after the 
 other MasterZookeeperTest)
 
 
 Thanks,
 
 Marco Massenzio
 




Review Request 36807: [WIP] Adding a test for MasterInfo

2015-07-24 Thread Marco Massenzio

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-2736
https://issues.apache.org/jira/browse/MESOS-2736


Repository: mesos


Description
---

We want to test that when the master gets initialized, the
MasterInfo that it creates (and gets ultimately serialized to
ZooKeeper) has the correct information in its Address field.

Currently, the test hangs when run in after another
MasterZooKeeperTest, due to some issues around the recovery.

Jira: MESOS-2736


Diffs
-

  src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 

Diff: https://reviews.apache.org/r/36807/diff/


Testing
---

make check
(the test by itself passes - but it will hang indefinitely when run after the 
other MasterZookeeperTest)


Thanks,

Marco Massenzio