Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-10-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/#review102435 --- Ship it! src/tests/fetcher_cache_tests.cpp (line 567)

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-10-13 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/ --- (Updated Oct. 13, 2015, 9:27 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/#review102480 --- Patch looks great! Reviews applied: [37813] All tests passed. -

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-10-12 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/ --- (Updated Oct. 12, 2015, 9:25 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/#review102278 --- Patch looks great! Reviews applied: [37813] All tests passed. -

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-09-18 Thread Joseph Wu
> On Aug. 26, 2015, 4:03 p.m., Joseph Wu wrote: > > Looks good. Any updates on this? (Haven't come across this test failure recently, but it's still nice to have.) - Joseph --- This is an automatically generated e-mail. To reply,

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-08-27 Thread Bernd Mathiske
On Aug. 26, 2015, 4:03 p.m., Joseph Wu wrote: src/tests/fetcher_cache_tests.cpp, line 458 https://reviews.apache.org/r/37813/diff/1/?file=1055256#file1055256line458 Is it common knowledge that the sandbox holds the logs? (If not, a short comment would suffice.) It kinda is, but

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-08-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/#review96607 --- Ship it! Looks good. src/tests/fetcher_cache_tests.cpp (line

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-08-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/#review96606 --- Patch looks great! Reviews applied: [37813] All tests passed. -

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

2015-08-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/ --- (Updated Aug. 26, 2015, 2:08 p.m.) Review request for mesos, Benjamin Hindman,