Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 5, 2015, 5:57 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Jojy Varghese
> On Nov. 5, 2015, 5:54 p.m., Timothy Chen wrote: > > Can you update the title to something more specific of what this patch does? updated. - Jojy --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38579: Refactored registry client

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 5, 2015, 4:03 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-11-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review105271 --- Can you update the title to something more specific of what this

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 5, 2015, 7:17 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Timothy Chen
> On Nov. 6, 2015, 2:54 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line > > 529 > > > > > > Can you use the new .status == http::Status::OK and simliar

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 6, 2015, 6:57 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review105352 ---

Re: Review Request 38579: Refactored registry client

2015-11-04 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 4, 2015, 6:07 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-11-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 2, 2015, 10:45 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-11-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 1, 2015, 3:28 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-14 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 14, 2015, 4:06 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 13, 2015, 7:18 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 9, 2015, 6:36 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 9, 2015, 12:58 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101621 --- Patch looks great! Reviews applied: [39013, 38443, 38579] All

Re: Review Request 38579: Refactored registry client

2015-10-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 5, 2015, 9:23 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 6, 2015, 2:32 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 6, 2015, 2:33 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-05 Thread Jojy Varghese
> On Oct. 2, 2015, 11:16 p.m., Ben Mahler wrote: > > src/slave/containerizer/provisioner/docker/registry_client.hpp, lines 36-40 > > > > > > Hm.. any reason the registry client is nested within the containerizer? > >

Re: Review Request 38579: Refactored registry client

2015-10-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101401 --- src/slave/containerizer/provisioner/docker/registry_client.cpp

Re: Review Request 38579: Refactored registry client

2015-10-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101382 --- Thanks for taking this on Jojy! This is going to be a great

Re: Review Request 38579: Refactored registry client

2015-10-02 Thread Jojy Varghese
> On Oct. 2, 2015, 11:16 p.m., Ben Mahler wrote: > > src/slave/containerizer/provisioner/docker/registry_client.hpp, lines 75-86 > > > > > > As it stands these comments don't seem to be adding any value over what >

Re: Review Request 38579: Refactored registry client

2015-10-01 Thread Jojy Varghese
> On Oct. 1, 2015, 6:49 p.m., Timothy Chen wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 557 > > > > > > Is this a bug fix? What was wrong? And why the tests pass before? Its not a bug fix.

Re: Review Request 38579: Refactored registry client

2015-10-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 1, 2015, 6:39 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101266 --- src/slave/containerizer/provisioner/docker/registry_client.cpp

Re: Review Request 38579: Refactored registry client

2015-10-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101267 --- Could you please split the changes here? Specifically it looks

Re: Review Request 38579: Refactored registry client

2015-10-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 2, 2015, 12:24 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client

2015-10-01 Thread Jojy Varghese
> On Oct. 1, 2015, 6:59 p.m., Ben Mahler wrote: > > Could you please split the changes here? Specifically it looks like pulling > > up the structs and the chagnes to control flow are independent. Done. Created https://reviews.apache.org/r/38941 - Jojy

Re: Review Request 38579: Refactored registry client

2015-09-30 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 1, 2015, 3:29 a.m.) Review request for mesos and Timothy Chen.