Re: Review Request 38837: CMake: Disable agent build on Windows.

2015-10-03 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/#review101416 --- Ship it! - Joris Van Remoortere On Sept. 29, 2015, 8:21 p.m.,

Re: Review Request 38837: CMake: Disable agent build on Windows.

2015-09-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/ --- (Updated Sept. 29, 2015, 4:49 p.m.) Review request for mesos, Artem

Re: Review Request 38837: CMake: Disable agent build on Windows.

2015-09-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/#review100974 --- Can you explain why you're disabling this part? (Is it simply not

Re: Review Request 38837: CMake: Disable agent build on Windows.

2015-09-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/#review101033 --- Patch looks great! Reviews applied: [38825, 38826, 38827, 38837]

Re: Review Request 38837: CMake: Disable agent build on Windows.

2015-09-29 Thread Alex Clemmer
> On Sept. 29, 2015, 5:06 p.m., Joseph Wu wrote: > > Can you explain why you're disabling this part? (Is it simply not > > implemented yet, so you're temporarily skipping it?) Mainly because the agent doesn't actually compile on Windows. I meant to put this up for review awhile ago but

Re: Review Request 38837: CMake: Disable agent build on Windows.

2015-09-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/ --- (Updated Sept. 29, 2015, 5:17 p.m.) Review request for mesos, Artem

Re: Review Request 38837: CMake: Disable agent build on Windows.

2015-09-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/ --- (Updated Sept. 29, 2015, 8:21 p.m.) Review request for mesos, Artem