Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/#review101680 --- Ship it! Thanks for pulling away the dependencies, I'll commit

Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/#review101530 --- I'd like to ship these smaller fixes, but they depend on the large

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/ --- (Updated Oct. 5, 2015, 9:21 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Ben Mahler
> On Oct. 5, 2015, 9:07 p.m., Ben Mahler wrote: > > I'd like to ship these smaller fixes, but they depend on the large refactor > > patch and the patch for new functionality, so I can't apply the change :( > > > > Please put the small cleanup patches at the front of your change so that > >

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/ --- (Updated Oct. 6, 2015, 2:30 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/#review101585 --- BTW, can you update