Re: Review Request 39923: Cleaned up configuration.md.

[Guangya Liu]

> On 一月 6, 2016, 12:26 a.m., Neil Conway wrote:
> > This introduces some inconsistencies between the text in `configuration.md` 
> > and the content of the various `flags.cpp` files (first thing I checked: 
> > "api" still appears in `src/logging/flags.cpp` but we now use "API" in 
> > `configuration.md`; likely other instances as well).
> 
> Guangya Liu wrote:
> @Neil, please refer to https://reviews.apache.org/r/41933/ , all of the 
> issues you mentioned are being fixed there.

@Neil, just filed a new JIRA ticket to trace those issues 
https://issues.apache.org/jira/browse/MESOS-4298 , the 
https://reviews.apache.org/r/41933/ is only handling authorizer part.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review112974
---


On 一月 5, 2016, 7:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated 一月 5, 2016, 7:53 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, Kapil Arya, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39923: Cleaned up configuration.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/
---

(Updated Jan. 5, 2016, 6:52 p.m.)


Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.


Changes
---

Rebase and additional edits.


Repository: mesos


Description
---

Edited configuration.md for style and consistency. Made consistent use of 
 for commands, flags, and flag values. Edited the libprocess flags 
for consistency and proper use of `=DIR` or `[=DIR]` depending on whether or 
not the directory is an optional parameter. Note that the libprocess `--with-*` 
flags have two different descriptions depending upon whether or not the library 
is bundled with Mesos.


Diffs (updated)
-

  docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 

Diff: https://reviews.apache.org/r/39923/diff/


Testing
---

Viewed with the mesos website container 
(https://github.com/mesosphere/mesos-website-container).


Thanks,

Greg Mann

Re: Review Request 39923: Cleaned up configuration.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/
---

(Updated Jan. 5, 2016, 7:53 p.m.)


Review request for mesos, Jojy Varghese, Joris Van Remoortere, Kapil Arya, and 
Till Toenshoff.


Repository: mesos


Description
---

Edited configuration.md for style and consistency. Made consistent use of 
 for commands, flags, and flag values. Edited the libprocess flags 
for consistency and proper use of `=DIR` or `[=DIR]` depending on whether or 
not the directory is an optional parameter. Note that the libprocess `--with-*` 
flags have two different descriptions depending upon whether or not the library 
is bundled with Mesos.


Diffs (updated)
-

  docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 

Diff: https://reviews.apache.org/r/39923/diff/


Testing
---

Viewed with the mesos website container 
(https://github.com/mesosphere/mesos-website-container).


Thanks,

Greg Mann

Re: Review Request 39923: Cleaned up configuration.md.

[Till Toenshoff]

> On Dec. 7, 2015, 9:42 p.m., Neil Conway wrote:
> > What is the status of this patch -- can someone (Till) commit it?
> 
> Greg Mann wrote:
> Looks like this is in need of a rebase, I'll update it.

Sry, did not have it on my radar -- it's always a good idea to add me as a 
reviewer for preventing this :).


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review109192
---


On Jan. 5, 2016, 6:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated Jan. 5, 2016, 6:52 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39923: Cleaned up configuration.md.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review112974
---


This introduces some inconsistencies between the text in `configuration.md` and 
the content of the various `flags.cpp` files (first thing I checked: "api" 
still appears in `src/logging/flags.cpp` but we now use "API" in 
`configuration.md`; likely other instances as well).

- Neil Conway


On Jan. 5, 2016, 7:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated Jan. 5, 2016, 7:53 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, Kapil Arya, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39923: Cleaned up configuration.md.

[Greg Mann]

> On Dec. 7, 2015, 9:42 p.m., Neil Conway wrote:
> > What is the status of this patch -- can someone (Till) commit it?

Looks like this is in need of a rebase, I'll update it.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review109192
---


On Nov. 7, 2015, 12:20 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated Nov. 7, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39923: Cleaned up configuration.md.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review109192
---


What is the status of this patch -- can someone (Till) commit it?

- Neil Conway


On Nov. 7, 2015, 12:20 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated Nov. 7, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39923: Cleaned up configuration.md.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review105585
---

Ship it!


Ship It!

- Till Toenshoff


On Nov. 7, 2015, 12:20 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated Nov. 7, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39923: Cleaned up configuration.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/
---

(Updated Nov. 7, 2015, 12:20 a.m.)


Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.


Changes
---

Rebase.


Repository: mesos


Description
---

Edited configuration.md for style and consistency. Made consistent use of 
 for commands, flags, and flag values. Edited the libprocess flags 
for consistency and proper use of `=DIR` or `[=DIR]` depending on whether or 
not the directory is an optional parameter. Note that the libprocess `--with-*` 
flags have two different descriptions depending upon whether or not the library 
is bundled with Mesos.


Diffs (updated)
-

  docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 

Diff: https://reviews.apache.org/r/39923/diff/


Testing
---

Viewed with the mesos website container 
(https://github.com/mesosphere/mesos-website-container).


Thanks,

Greg Mann

Re: Review Request 39923: Cleaned up configuration.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review105569
---


Bad patch!

Reviews applied: [39923]

Failed command: ./support/apply-review.sh -n -r 39923

Error:
 2015-11-07 03:23:49 URL:https://reviews.apache.org/r/39923/diff/raw/ 
[54692/54692] -> "39923.patch" [1]
error: patch failed: docs/configuration.md:410
error: docs/configuration.md: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 7, 2015, 12:20 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated Nov. 7, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 39923: Cleaned up configuration.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/
---

Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.


Repository: mesos


Description
---

Edited configuration.md for style and consistency. Made consistent use of 
 for commands, flags, and flag values. Edited the libprocess flags 
for consistency and proper use of `=DIR` or `[=DIR]` depending on whether or 
not the directory is an optional parameter. Note that the libprocess `--with-*` 
flags have two different descriptions depending upon whether or not the library 
is bundled with Mesos.


Diffs
-

  docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 

Diff: https://reviews.apache.org/r/39923/diff/


Testing
---

Viewed with the mesos website container 
(https://github.com/mesosphere/mesos-website-container).


Thanks,

Greg Mann

Re: Review Request 39923: Cleaned up configuration.md.

[Greg Mann]

> On Nov. 4, 2015, 12:29 a.m., Guangya Liu wrote:
> > docs/configuration.md, line 792
> > 
> >
> > Why remove this?

The text already states "A path to a file containing either one of the above 
options.", and I thought that it makes this line a bit redundant.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review105018
---


On Nov. 4, 2015, 12:16 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated Nov. 4, 2015, 12:16 a.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39923: Cleaned up configuration.md.

[Guangya Liu]

> On 十一月 4, 2015, 12:29 a.m., Guangya Liu wrote:
> > docs/configuration.md, line 792
> > 
> >
> > Why remove this?
> 
> Greg Mann wrote:
> The text already states "A path to a file containing either one of the 
> above options.", and I thought that it makes this line a bit redundant.

Fair enogh. Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review105018
---


On 十一月 4, 2015, 12:16 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated 十一月 4, 2015, 12:16 a.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39923: Cleaned up configuration.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review105033
---


Patch looks great!

Reviews applied: [39923]

All tests passed.

- Mesos ReviewBot


On Nov. 4, 2015, 12:16 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated Nov. 4, 2015, 12:16 a.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>