Re: Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-16 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41383/#review110800
---

Ship it!


Ship It!

- Jojy Varghese


On Dec. 16, 2015, 11:06 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41383/
> ---
> 
> (Updated Dec. 16, 2015, 11:06 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Gilbert Song, Jojy Varghese, and 
> Neil Conway.
> 
> 
> Bugs: MESOS-3305
> https://issues.apache.org/jira/browse/MESOS-3305
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit updates the Getting Started guide for ubuntu 14.04 to
> explicitly list libsasl2-modules as a dependence for its system
> requirements. It's possible that the stock ubuntu image comes with this
> package automatically installed (e.g. the default ubuntu/trusty64 image
> on atlas has it pre-installed). Regardless, we need to ensure that
> it is installed before we build mesos, so we list it here.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41383/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Re: Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-16 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41383/#review110792
---

Ship it!


Totally agreed with ensuring this package installed, because of different 
versions of ubuntu14.04.

- Gilbert Song


On Dec. 16, 2015, 3:06 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41383/
> ---
> 
> (Updated Dec. 16, 2015, 3:06 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Gilbert Song, Jojy Varghese, and 
> Neil Conway.
> 
> 
> Bugs: MESOS-3305
> https://issues.apache.org/jira/browse/MESOS-3305
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit updates the Getting Started guide for ubuntu 14.04 to
> explicitly list libsasl2-modules as a dependence for its system
> requirements. It's possible that the stock ubuntu image comes with this
> package automatically installed (e.g. the default ubuntu/trusty64 image
> on atlas has it pre-installed). Regardless, we need to ensure that
> it is installed before we build mesos, so we list it here.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41383/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Re: Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-16 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41383/#review110855
---

Ship it!


Ship It!

- Till Toenshoff


On Dec. 16, 2015, 11:06 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41383/
> ---
> 
> (Updated Dec. 16, 2015, 11:06 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Gilbert Song, Jojy Varghese, and 
> Neil Conway.
> 
> 
> Bugs: MESOS-3305
> https://issues.apache.org/jira/browse/MESOS-3305
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit updates the Getting Started guide for ubuntu 14.04 to
> explicitly list libsasl2-modules as a dependence for its system
> requirements. It's possible that the stock ubuntu image comes with this
> package automatically installed (e.g. the default ubuntu/trusty64 image
> on atlas has it pre-installed). Regardless, we need to ensure that
> it is installed before we build mesos, so we list it here.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41383/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-14 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41383/
---

Review request for mesos, Bernd Mathiske and Neil Conway.


Bugs: MESOS-3305
https://issues.apache.org/jira/browse/MESOS-3305


Repository: mesos


Description
---

This commit updates the Getting Started guide for ubuntu 14.04 to
explicitly list libsasl2-modules as a dependence for its system
requirements. It's possible that the stock ubuntu image comes with this
package automatically installed (e.g. the default ubuntu/trusty64 image
on atlas has it pre-installed). Regardless, we need to ensure that
it is installed before we build mesos, so we list it here.


Diffs
-

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41383/diff/


Testing
---


Thanks,

Kevin Klues



Re: Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-14 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41383/#review110409
---


Patch looks great!

Reviews applied: [41286, 41359, 41360, 41361, 41362, 41363, 41364, 41371, 
41372, 41383]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 15, 2015, 1:28 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41383/
> ---
> 
> (Updated Dec. 15, 2015, 1:28 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Neil Conway.
> 
> 
> Bugs: MESOS-3305
> https://issues.apache.org/jira/browse/MESOS-3305
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit updates the Getting Started guide for ubuntu 14.04 to
> explicitly list libsasl2-modules as a dependence for its system
> requirements. It's possible that the stock ubuntu image comes with this
> package automatically installed (e.g. the default ubuntu/trusty64 image
> on atlas has it pre-installed). Regardless, we need to ensure that
> it is installed before we build mesos, so we list it here.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41383/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>