Re: Review Request 43521: Speed up OversubscriptionTest.UpdateAllocatorOnSchedulerFailover.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43521/#review128384
---


Fix it, then Ship it!





src/tests/oversubscription_tests.cpp (line 1000)


I understand why you need to make this change now, but I think we can kill 
this comment, because it's not surprising that we wait for registration first 
and then for offers.


- Alexander Rukletsov


On April 8, 2016, 6:38 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43521/
> ---
> 
> (Updated April 8, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4170
> https://issues.apache.org/jira/browse/MESOS-4170
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up OversubscriptionTest.UpdateAllocatorOnSchedulerFailover by advance 
> allocation interval.
> 
> 
> Diffs
> -
> 
>   src/tests/oversubscription_tests.cpp 
> 23671746da2ac505d75bc2bd59114697d9161d52 
> 
> Diff: https://reviews.apache.org/r/43521/diff/
> 
> 
> Testing
> ---
> 
> Repeat test on CentOS 7.1
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="OversubscriptionTest.UpdateAllocatorOnSchedulerFailover" 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43521: Speed up OversubscriptionTest.UpdateAllocatorOnSchedulerFailover.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43521/
---

(Updated April 8, 2016, 6:35 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Update according to @alex's comments.


Bugs: MESOS-4170
https://issues.apache.org/jira/browse/MESOS-4170


Repository: mesos


Description (updated)
---

Speed up OversubscriptionTest.UpdateAllocatorOnSchedulerFailover by advance 
allocation interval.


Diffs (updated)
-

  src/tests/oversubscription_tests.cpp 23671746da2ac505d75bc2bd59114697d9161d52 

Diff: https://reviews.apache.org/r/43521/diff/


Testing (updated)
---

Repeat test on CentOS 7.1

```
sudo ./bin/mesos-tests.sh 
--gtest_filter="OversubscriptionTest.UpdateAllocatorOnSchedulerFailover" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang

Review Request 43521: Speed up OversubscriptionTest.UpdateAllocatorOnSchedulerFailover.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43521/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4170
https://issues.apache.org/jira/browse/MESOS-4170


Repository: mesos


Description
---

Speed up OversubscriptionTest.UpdateAllocatorOnSchedulerFailover.


Diffs
-

  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 

Diff: https://reviews.apache.org/r/43521/diff/


Testing
---


Thanks,

haosdent huang