Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-23 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/#review120420
---


Ship it!




Ship It!

- Jie Yu


On Feb. 22, 2016, 10:52 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43854/
> ---
> 
> (Updated Feb. 22, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed chdir to an empty directory error.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 
> 
> Diff: https://reviews.apache.org/r/43854/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> Tested with /mesos-execute --docker_image=busybox
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-23 Thread Jie Yu 


> On Feb. 23, 2016, 6:40 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 354
> > 
> >
> > Do we have tests to test the docker runtime isolator?

Yeah, I think he's adding one. Need a few test abstractions to do that.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/#review120268
---


On Feb. 22, 2016, 10:52 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43854/
> ---
> 
> (Updated Feb. 22, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed chdir to an empty directory error.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 
> 
> Diff: https://reviews.apache.org/r/43854/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> Tested with /mesos-execute --docker_image=busybox
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-22 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/#review120268
---




src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 354)


Do we have tests to test the docker runtime isolator?


- Timothy Chen


On Feb. 22, 2016, 10:52 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43854/
> ---
> 
> (Updated Feb. 22, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed chdir to an empty directory error.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 
> 
> Diff: https://reviews.apache.org/r/43854/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> Tested with /mesos-execute --docker_image=busybox
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/#review120261
---



Patch looks great!

Reviews applied: [43854]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 10:52 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43854/
> ---
> 
> (Updated Feb. 22, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed chdir to an empty directory error.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 
> 
> Diff: https://reviews.apache.org/r/43854/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> Tested with /mesos-execute --docker_image=busybox
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 43854: Fixed chdir to an empty directory error.

2016-02-22 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Fixed chdir to an empty directory error.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 

Diff: https://reviews.apache.org/r/43854/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)

Tested with /mesos-execute --docker_image=busybox


Thanks,

Gilbert Song

Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-22 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/
---

(Updated Feb. 22, 2016, 2:52 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Fixed chdir to an empty directory error.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6 

Diff: https://reviews.apache.org/r/43854/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)

Tested with /mesos-execute --docker_image=busybox


Thanks,

Gilbert Song