Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review128344
---



Patch looks great!

Reviews applied: [42705, 44606]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 12, 2016, 5:20 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated April 12, 2016, 5:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -
> 
>   CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3 
>   docs/endpoints/master/create-volumes.md 
> 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md 
> a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp 626c88f85910c4e476194f203341c4db7053e0f0 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-11 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
---

(Updated 四月 12, 2016, 5:20 a.m.)


Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Changes
---

rebase and update the code per Neil's comments


Bugs: mesos-4580
https://issues.apache.org/jira/browse/mesos-4580


Repository: mesos


Description
---

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]


Diffs (updated)
-

  CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3 
  docs/endpoints/master/create-volumes.md 
52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
  docs/endpoints/master/destroy-volumes.md 
a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
  docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
  docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
  docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
  docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
  docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
  src/master/http.cpp 626c88f85910c4e476194f203341c4db7053e0f0 
  src/tests/persistent_volume_endpoints_tests.cpp 
9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
  src/tests/reservation_endpoints_tests.cpp 
2e0f6c1aba95d918b8c42219ee97f79f1070d56e 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
---


Thanks,

zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-11 Thread zhou xing 


> On 四月 7, 2016, 10:13 p.m., Neil Conway wrote:
> > docs/persistent-volume.md, line 296
> > 
> >
> > Replace "Returns `202 ACCEPTED` which" with "This endpoint returns the 
> > `202 ACCEPTED` HTTP status code, which " -- here and below.

Thanks Neil for your review


> On 四月 7, 2016, 10:13 p.m., Neil Conway wrote:
> > docs/upgrades.md, line 167
> > 
> >
> > Replace "return code" with "HTTP status code"
> > 
> > I think you can just remove "which may introduce backwards 
> > incompatibility issue" (if we're keeping it, the grammar isn't quite right).

Thanks Neil for your review


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127678
---


On 四月 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated 四月 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 
> 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md 
> a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-07 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127678
---


Fix it, then Ship it!





docs/persistent-volume.md (line 296)


Replace "Returns `202 ACCEPTED` which" with "This endpoint returns the `202 
ACCEPTED` HTTP status code, which " -- here and below.



docs/upgrades.md (line 167)


Replace "return code" with "HTTP status code"

I think you can just remove "which may introduce backwards incompatibility 
issue" (if we're keeping it, the grammar isn't quite right).


- Neil Conway


On April 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated April 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 
> 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md 
> a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-07 Thread Neil Conway 


> On March 18, 2016, 6:51 p.m., Vinod Kone wrote:
> > Looks good to me. Couple of things before this can get committed.
> > 
> > --> Have you sent an email to dev/user list about this backwards 
> > incompatible change? If not, you should.
> >  
> > --> If users are depending on the return code (need to ask on the above 
> > email) we need to do a proper deprecation warning in 0.29.0 CHANGELOG 
> > (Deprecations section) and change the behavior in 0.30.0.
> > 
> > --> If no one is depending on the return code, we might just do the change 
> > in 0.29.0. This should go into the 0.29.0 CHANGELOG though (API Changes 
> > section).
> 
> zhou xing wrote:
> Thanks for the review, we have sent a message to the community to see 
> wether anyone are using the return code. will update you the latest feedbacks 
> we collect, thx
> 
> Kevin Klues wrote:
> I Zhao, I'm curious if you got any feedback on this.  Also, did you get a 
> chance to address Neil's comments about updating the documentation? I think 
> that would need to be included as part of this work, though I'd probably 
> submit it as a separate patch that "Depends On" this one.
> 
> zhou xing wrote:
> Kevin, we haven't got any response for this issue from the community yet. 
> So I'm thinking whether we can just merge this patch in release 0.29? if so, 
> I can update the change log and submit another patch, thanks

I think making this change in 0.29 is probably reasonable, provided we include 
the appropriate notices in the release notes / changelog / update doc.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review124249
---


On April 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated April 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 
> 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md 
> a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127578
---



Patch looks great!

Reviews applied: [42705, 44606]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated April 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 
> 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md 
> a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-07 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
---

(Updated April 7, 2016, 8:56 a.m.)


Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Changes
---

rebased code and add CHANGELOG


Bugs: mesos-4580
https://issues.apache.org/jira/browse/mesos-4580


Repository: mesos


Description (updated)
---

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]


Diffs (updated)
-

  CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
  docs/endpoints/master/create-volumes.md 
52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
  docs/endpoints/master/destroy-volumes.md 
a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
  docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
  docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
  docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
  docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
  docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
  src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
  src/tests/persistent_volume_endpoints_tests.cpp 
9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
  src/tests/reservation_endpoints_tests.cpp 
2e0f6c1aba95d918b8c42219ee97f79f1070d56e 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
---


Thanks,

zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-27 Thread zhou xing 


> On 三月 18, 2016, 6:51 p.m., Vinod Kone wrote:
> > Looks good to me. Couple of things before this can get committed.
> > 
> > --> Have you sent an email to dev/user list about this backwards 
> > incompatible change? If not, you should.
> >  
> > --> If users are depending on the return code (need to ask on the above 
> > email) we need to do a proper deprecation warning in 0.29.0 CHANGELOG 
> > (Deprecations section) and change the behavior in 0.30.0.
> > 
> > --> If no one is depending on the return code, we might just do the change 
> > in 0.29.0. This should go into the 0.29.0 CHANGELOG though (API Changes 
> > section).
> 
> zhou xing wrote:
> Thanks for the review, we have sent a message to the community to see 
> wether anyone are using the return code. will update you the latest feedbacks 
> we collect, thx
> 
> Kevin Klues wrote:
> I Zhao, I'm curious if you got any feedback on this.  Also, did you get a 
> chance to address Neil's comments about updating the documentation? I think 
> that would need to be included as part of this work, though I'd probably 
> submit it as a separate patch that "Depends On" this one.

Kevin, we haven't got any response for this issue from the community yet. So 
I'm thinking whether we can just merge this patch in release 0.29? if so, I can 
update the change log and submit another patch, thanks


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review124249
---


On 三月 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated 三月 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan 
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md 
> d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-25 Thread Kevin Klues 


> On March 18, 2016, 6:51 p.m., Vinod Kone wrote:
> > Looks good to me. Couple of things before this can get committed.
> > 
> > --> Have you sent an email to dev/user list about this backwards 
> > incompatible change? If not, you should.
> >  
> > --> If users are depending on the return code (need to ask on the above 
> > email) we need to do a proper deprecation warning in 0.29.0 CHANGELOG 
> > (Deprecations section) and change the behavior in 0.30.0.
> > 
> > --> If no one is depending on the return code, we might just do the change 
> > in 0.29.0. This should go into the 0.29.0 CHANGELOG though (API Changes 
> > section).
> 
> zhou xing wrote:
> Thanks for the review, we have sent a message to the community to see 
> wether anyone are using the return code. will update you the latest feedbacks 
> we collect, thx

I Zhao, I'm curious if you got any feedback on this.  Also, did you get a 
chance to address Neil's comments about updating the documentation? I think 
that would need to be included as part of this work, though I'd probably submit 
it as a separate patch that "Depends On" this one.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review124249
---


On March 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated March 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan 
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md 
> d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-19 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review124249
---



Looks good to me. Couple of things before this can get committed.

--> Have you sent an email to dev/user list about this backwards incompatible 
change? If not, you should.
 
--> If users are depending on the return code (need to ask on the above email) 
we need to do a proper deprecation warning in 0.29.0 CHANGELOG (Deprecations 
section) and change the behavior in 0.30.0.

--> If no one is depending on the return code, we might just do the change in 
0.29.0. This should go into the 0.29.0 CHANGELOG though (API Changes section).

- Vinod Kone


On March 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated March 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan 
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md 
> d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review122900
---



Patch looks great!

Reviews applied: [42705, 44606]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated March 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan 
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md 
> d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread zhou xing 


> On 三月 10, 2016, 5:21 a.m., Neil Conway wrote:
> > src/tests/persistent_volume_endpoints_tests.cpp, line 60
> > 
> >
> > "using" directives should be sorted alphabetically.

Thanks for the review, has updated the patch


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review122879
---


On 三月 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated 三月 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan 
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md 
> d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
---

(Updated 三月 10, 2016, 7:11 a.m.)


Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Bugs: mesos-4580
https://issues.apache.org/jira/browse/mesos-4580


Repository: mesos


Description
---

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]

Signed-off-by: Guo Jiannan 


Diffs (updated)
-

  docs/endpoints/master/create-volumes.md 
542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
  docs/endpoints/master/destroy-volumes.md 
d5d98198e70fae4f6ea6791511f3b26e792f66d1 
  docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
  docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
  docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
  docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
  docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
  src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
  src/tests/persistent_volume_endpoints_tests.cpp 
81185a161498394020a27f1f5bf747bac5425f43 
  src/tests/reservation_endpoints_tests.cpp 
f95ae7a32c3809d150adf1e9e515a3b527e61699 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
---


Thanks,

zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review122879
---



Can you also update the documentation? In particular, 
`docs/persistent-volume.md`, `docs/reservation.md`, and add a note about the 
backward-incompatible change to `upgrades.md`.


src/tests/persistent_volume_endpoints_tests.cpp (line 60)


"using" directives should be sorted alphabetically.


- Neil Conway


On March 10, 2016, 3:41 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated March 10, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan 
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
---

Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Repository: mesos


Description
---

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]

Signed-off-by: Guo Jiannan 


Diffs
-

  src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
  src/tests/persistent_volume_endpoints_tests.cpp 
81185a161498394020a27f1f5bf747bac5425f43 
  src/tests/reservation_endpoints_tests.cpp 
f95ae7a32c3809d150adf1e9e515a3b527e61699 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
---


Thanks,

zhou xing