Re: Review Request 44765: Added description to endpoint help for frameworks and flags.

2016-03-14 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44765/#review123376
---




src/master/http.cpp (line 737)


s/of/about/



src/master/http.cpp (line 780)


What about `Slave::Http::FLAGS_HELP()`?



src/master/http.cpp (line 786)


s/provides information/shows/


- Adam B


On March 13, 2016, 2:29 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44765/
> ---
> 
> (Updated March 13, 2016, 2:29 p.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added description to endpoint help for frameworks and flags.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/flags.md 739d6bfae5ae35223d6bc7c4782ff0f16b868018 
>   docs/endpoints/master/frameworks.md 
> 95c1f0e63f6a61d0e6622a8ec9d821a646656cfc 
>   src/master/http.cpp 6dec322ca4f7d81c2f070db4f54a0575a2b5c842 
> 
> Diff: https://reviews.apache.org/r/44765/diff/
> 
> 
> Testing
> ---
> 
> Viewed in browser.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44765: Added description to endpoint help for frameworks and flags.

2016-03-13 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44765/#review123343
---



Patch looks great!

Reviews applied: [44286, 44186, 44621, 44711, 44764, 44765]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 13, 2016, 9:29 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44765/
> ---
> 
> (Updated March 13, 2016, 9:29 p.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added description to endpoint help for frameworks and flags.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/flags.md 739d6bfae5ae35223d6bc7c4782ff0f16b868018 
>   docs/endpoints/master/frameworks.md 
> 95c1f0e63f6a61d0e6622a8ec9d821a646656cfc 
>   src/master/http.cpp 6dec322ca4f7d81c2f070db4f54a0575a2b5c842 
> 
> Diff: https://reviews.apache.org/r/44765/diff/
> 
> 
> Testing
> ---
> 
> Viewed in browser.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44765: Added description to endpoint help for frameworks and flags.

2016-03-13 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44765/
---

(Updated March 13, 2016, 9:29 p.m.)


Review request for mesos, Adam B and Neil Conway.


Changes
---

Generated endpoint documentation.


Repository: mesos


Description (updated)
---

Added description to endpoint help for frameworks and flags.


Diffs (updated)
-

  docs/endpoints/master/flags.md 739d6bfae5ae35223d6bc7c4782ff0f16b868018 
  docs/endpoints/master/frameworks.md 95c1f0e63f6a61d0e6622a8ec9d821a646656cfc 
  src/master/http.cpp 6dec322ca4f7d81c2f070db4f54a0575a2b5c842 

Diff: https://reviews.apache.org/r/44765/diff/


Testing
---

Viewed in browser.


Thanks,

Joerg Schad

Re: Review Request 44765: Added description to endpoint help for frameworks and flags.

2016-03-13 Thread Joerg Schad 


> On March 13, 2016, 8:40 p.m., Kevin Klues wrote:
> > Can you also run the support/generate-endpoint-ehlp.py sript to regenerate 
> > the mardown files for the endpoints help?

Already considered that :-).


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44765/#review123329
---


On March 13, 2016, 8:21 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44765/
> ---
> 
> (Updated March 13, 2016, 8:21 p.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> All other endpoints provide a description which specifies at least the type 
> of object returned.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6dec322ca4f7d81c2f070db4f54a0575a2b5c842 
> 
> Diff: https://reviews.apache.org/r/44765/diff/
> 
> 
> Testing
> ---
> 
> Viewed in browser.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44765: Added description to endpoint help for frameworks and flags.

2016-03-13 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44765/#review123329
---



Can you also run the support/generate-endpoint-ehlp.py sript to regenerate the 
mardown files for the endpoints help?

- Kevin Klues


On March 13, 2016, 8:21 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44765/
> ---
> 
> (Updated March 13, 2016, 8:21 p.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> All other endpoints provide a description which specifies at least the type 
> of object returned.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6dec322ca4f7d81c2f070db4f54a0575a2b5c842 
> 
> Diff: https://reviews.apache.org/r/44765/diff/
> 
> 
> Testing
> ---
> 
> Viewed in browser.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 44765: Added description to endpoint help for frameworks and flags.

2016-03-13 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44765/
---

Review request for mesos, Adam B and Neil Conway.


Repository: mesos


Description
---

All other endpoints provide a description which specifies at least the type of 
object returned.


Diffs
-

  src/master/http.cpp 6dec322ca4f7d81c2f070db4f54a0575a2b5c842 

Diff: https://reviews.apache.org/r/44765/diff/


Testing
---

Viewed in browser.


Thanks,

Joerg Schad