Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review134420 --- Fix it, then Ship it!

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/ --- (Updated 五月 14, 2016, 12:58 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

> On 五月 12, 2016, 10:34 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp, line > > 174 > > > > > > since you already have the check above, why dont you return

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/ --- (Updated 五月 13, 2016, 3:26 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

> On 五月 12, 2016, 10:34 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp, > > lines 169-176 > > > > > > btw, I would prefer check forcepulling after

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review132994 --- Fix it, then Ship it!

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/ --- (Updated 四月 18, 2016, 8:31 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review123622 --- Ship it! Ship It! - haosdent huang On March 15, 2016, 7:55

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

> On March 15, 2016, 7:42 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, line 188 > > > > > > Because we don't set default value of `force_pull_image` in protobuf > >

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/ --- (Updated 三月 15, 2016, 7:55 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

> On 三月 15, 2016, 7:34 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp, line > > 93 > > > > > > Should we have default value for `forcePullImage`, for example:

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

> On 三月 15, 2016, 7:42 a.m., haosdent huang wrote: > > And seems don't contains `appc` part in this patch? AppC will be handled in the following patch. > On 三月 15, 2016, 7:42 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, line 188 > >

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review123614 --- And seems don't contains `appc` part in this patch?

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review123612 ---

Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4886