Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 6, 2016, 12:18 a.m., Jiang Yan Xu wrote: > > src/tests/cluster.hpp, line 188 > > > > > > These are default initialized anyways but explicitness is good. There is a non-default constructor and these had

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review127259 --- Ship it! src/tests/cluster.hpp (line 188)

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/ --- (Updated April 5, 2016, 11:41 p.m.) Review request for mesos, Joris Van

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 5, 2016, 12:52 p.m., Joseph Wu wrote: > > src/tests/cluster.cpp, lines 364-366 > > > > > > The destructor will only dereference a null `containerizer` if this > > error case is hit (or if you pass in a

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review127195 --- src/tests/cluster.cpp (lines 364 - 366)

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 5:35 p.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 5:35 p.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` +1 this is

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review126867 --- Not insisting on addressing it here but just would like to

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review126866 --- src/tests/cluster.cpp (line 437)

Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/ --- Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.