Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/#review130165 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 3:15

Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/#review130161 --- Patch looks great! Reviews applied: [46469] Passed command:

Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-22 Thread Tim Anderegg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/ --- (Updated April 22, 2016, 3:15 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-22 Thread Tim Anderegg
> On April 22, 2016, 1:19 a.m., Vinod Kone wrote: > > src/cli/execute.cpp, line 754 > > > > > > I think it is ok to set principal and not secret. We should just set > > the framework info principal in that case. >

Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/#review130012 --- src/cli/execute.cpp (line 754)

Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/#review129852 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 46469: Added support for credentials to mesos-execute.

2016-04-20 Thread Tim Anderegg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/ --- Review request for mesos. Bugs: MESOS-3402