Re: Review Request 47106: Corrected variable names and 'empty' histogram detection logic.

2017-03-01 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47106/#review167302
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On May 9, 2016, 3:20 p.m., Chris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47106/
> ---
> 
> (Updated May 9, 2016, 3:20 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-5342
> https://issues.apache.org/jira/browse/MESOS-5342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected variable names and 'empty' histogram detection logic.
> 
> 
> Diffs
> -
> 
>   
> src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/ProcessBinder.hpp
>  PRE-CREATION 
>   
> src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/ProcessBinder.cpp
>  PRE-CREATION 
>   
> src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.hpp
>  PRE-CREATION 
>   
> src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.cpp
>  PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/hwloc.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/hwloc.cpp 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/47106/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chris
> 
>



Review Request 47106: Corrected variable names and 'empty' histogram detection logic.

2016-05-09 Thread Chris

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47106/
---

Review request for mesos.


Bugs: MESOS-5342
https://issues.apache.org/jira/browse/MESOS-5342


Repository: mesos


Description
---

Corrected variable names and 'empty' histogram detection logic.


Diffs
-

  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/ProcessBinder.hpp 
PRE-CREATION 
  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/ProcessBinder.cpp 
PRE-CREATION 
  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.hpp
 PRE-CREATION 
  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.cpp
 PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/hwloc.hpp 
PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/hwloc.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47106/diff/


Testing
---


Thanks,

Chris