Re: Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).

[Joseph Wu]

> On May 23, 2016, 8:17 p.m., Kapil Arya wrote:
> > 3rdparty/stout/include/stout/flags/flags.hpp, line 1027
> > 
> >
> > Just curious, will it do the right thing for boolean flags such as 
> > `--quiet`, `--no-quiet`, `--version` and `--no-version`?

Those flags will be transformed like:
```
--quiet  => --quiet=true
--no-quiet   => --quiet=false
--version=> --version=true
--no-version => --version=false
```

Round-trips will work, but we don't preserve the flags *exactly* as they are 
passed in.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47213/#review134502
---


On May 16, 2016, 11 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47213/
> ---
> 
> (Updated May 16, 2016, 11 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `stringify(flags)` will return a version of the flags that can be passed
> through `/bin/sh` for execution.  This method returns the same flags,
> but in a more `exec`-friendly form.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> 91542f56431579be8a3da5ec6e3e58f68e7dfcbe 
> 
> Diff: https://reviews.apache.org/r/47213/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47213/#review134502
---


Ship it!





3rdparty/stout/include/stout/flags/flags.hpp (line 1027)


Just curious, will it do the right thing for boolean flags such as 
`--quiet`, `--no-quiet`, `--version` and `--no-version`?


- Kapil Arya


On May 16, 2016, 2 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47213/
> ---
> 
> (Updated May 16, 2016, 2 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `stringify(flags)` will return a version of the flags that can be passed
> through `/bin/sh` for execution.  This method returns the same flags,
> but in a more `exec`-friendly form.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> 91542f56431579be8a3da5ec6e3e58f68e7dfcbe 
> 
> Diff: https://reviews.apache.org/r/47213/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47213/
---

(Updated May 16, 2016, 11 a.m.)


Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.


Changes
---

Rebase on top of the 3rdparty renaming change.


Bugs: MESOS-5350
https://issues.apache.org/jira/browse/MESOS-5350


Repository: mesos


Description
---

`stringify(flags)` will return a version of the flags that can be passed
through `/bin/sh` for execution.  This method returns the same flags,
but in a more `exec`-friendly form.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
91542f56431579be8a3da5ec6e3e58f68e7dfcbe 

Diff: https://reviews.apache.org/r/47213/diff/


Testing
---

make check


Thanks,

Joseph Wu

Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47213/
---

Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.


Bugs: MESOS-5350
https://issues.apache.org/jira/browse/MESOS-5350


Repository: mesos


Description
---

`stringify(flags)` will return a version of the flags that can be passed
through `/bin/sh` for execution.  This method returns the same flags,
but in a more `exec`-friendly form.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/47213/diff/


Testing
---

make check


Thanks,

Joseph Wu