Re: Review Request 51845: Improved SlaveTest.HealthCheckUnregisterRace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51845/#review148814 --- Ship it! Ship It! - Vinod Kone On Sept. 13, 2016, 12:58 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51845/ > --- > > (Updated Sept. 13, 2016, 12:58 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Now that the MockRegistrar has been introduced, we can assert > that the master doesn't do a registry operation in certain > situations. > > > Diffs > - > > src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 > > Diff: https://reviews.apache.org/r/51845/diff/ > > > Testing > --- > > make check > > > Thanks, > > Neil Conway > >
Re: Review Request 51845: Improved SlaveTest.HealthCheckUnregisterRace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51845/#review148752 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 50702, 50703, 50704, 50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 51374, 51375, 51376, 51377, 51021, 51706, 51653, 51707, 51805, 51845] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 13, 2016, 12:58 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51845/ > --- > > (Updated Sept. 13, 2016, 12:58 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Now that the MockRegistrar has been introduced, we can assert > that the master doesn't do a registry operation in certain > situations. > > > Diffs > - > > src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 > > Diff: https://reviews.apache.org/r/51845/diff/ > > > Testing > --- > > make check > > > Thanks, > > Neil Conway > >
Review Request 51845: Improved SlaveTest.HealthCheckUnregisterRace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51845/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --- Now that the MockRegistrar has been introduced, we can assert that the master doesn't do a registry operation in certain situations. Diffs - src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 Diff: https://reviews.apache.org/r/51845/diff/ Testing --- make check Thanks, Neil Conway