Re: Review Request 52097: Functionality to switch user when executor launches as non-root user.

2016-09-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52097/#review149890 --- src/slave/container_loggers/logrotate.cpp (lines 203 - 205)

Re: Review Request 52097: Functionality to switch user when executor launches as non-root user.

2016-09-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52097/#review149888 --- You have odd spacing throughout your patch. We use 2 spaces per

Re: Review Request 52097: Functionality to switch user when executor launches as non-root user.

2016-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52097/#review149814 --- Patch looks great! Reviews applied: [52095, 52096, 52097]

Re: Review Request 52097: Functionality to switch user when executor launches as non-root user.

2016-09-20 Thread Sivaram Kannan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52097/ --- (Updated Sept. 21, 2016, 3:54 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52097: Functionality to switch user when executor launches as non-root user.

2016-09-20 Thread Sivaram Kannan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52097/ --- (Updated Sept. 21, 2016, 1:02 a.m.) Review request for mesos and Joseph Wu.

Review Request 52097: Functionality to switch user when executor launches as non-root user.

2016-09-20 Thread Sivaram Kannan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52097/ --- Review request for mesos and Joseph Wu. Repository: mesos Description