Re: Review Request 52814: Added notes to the getting started and upgrade docs about --runtime_dir.

2016-10-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52814/#review152625
---



Patch looks great!

Reviews applied: [52814]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 13, 2016, 5:04 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52814/
> ---
> 
> (Updated Oct. 13, 2016, 5:04 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, Till Toenshoff, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-6312
> https://issues.apache.org/jira/browse/MESOS-6312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added notes to the getting started and upgrade docs about --runtime_dir.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md de3fba4a821ca7fa9b9e2fd692b33b40edd35b68 
>   docs/upgrades.md 8e45fdbb485829930f9b918d1d6f24893228e873 
> 
> Diff: https://reviews.apache.org/r/52814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Re: Review Request 52814: Added notes to the getting started and upgrade docs about --runtime_dir.

2016-10-13 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52814/
---

(Updated Oct. 13, 2016, 5:04 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, Till Toenshoff, and 
Vinod Kone.


Changes
---

Rebased on master.


Bugs: MESOS-6312
https://issues.apache.org/jira/browse/MESOS-6312


Repository: mesos


Description
---

Added notes to the getting started and upgrade docs about --runtime_dir.


Diffs (updated)
-

  docs/getting-started.md de3fba4a821ca7fa9b9e2fd692b33b40edd35b68 
  docs/upgrades.md 8e45fdbb485829930f9b918d1d6f24893228e873 

Diff: https://reviews.apache.org/r/52814/diff/


Testing
---


Thanks,

Kevin Klues



Re: Review Request 52814: Added notes to the getting started and upgrade docs about --runtime_dir.

2016-10-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52814/#review152467
---



Bad patch!

Reviews applied: [52814]

Failed command: ./support/apply-review.sh -n -r 52814

Error:
2016-10-13 08:32:52 URL:https://reviews.apache.org/r/52814/diff/raw/ 
[2616/2616] -> "52814.patch" [1]
error: patch failed: docs/upgrades.md:208
error: docs/upgrades.md: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15651/console

- Mesos ReviewBot


On Oct. 13, 2016, 1:51 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52814/
> ---
> 
> (Updated Oct. 13, 2016, 1:51 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, Till Toenshoff, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-6312
> https://issues.apache.org/jira/browse/MESOS-6312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added notes to the getting started and upgrade docs about --runtime_dir.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md de3fba4a821ca7fa9b9e2fd692b33b40edd35b68 
>   docs/upgrades.md 7250259590db322121a0f30d1cdb0f3732a7a6ee 
> 
> Diff: https://reviews.apache.org/r/52814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Review Request 52814: Added notes to the getting started and upgrade docs about --runtime_dir.

2016-10-12 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52814/
---

Review request for mesos, Alexander Rukletsov, Jie Yu, Till Toenshoff, and 
Vinod Kone.


Bugs: MESOS-6312
https://issues.apache.org/jira/browse/MESOS-6312


Repository: mesos


Description
---

Added notes to the getting started and upgrade docs about --runtime_dir.


Diffs
-

  docs/getting-started.md de3fba4a821ca7fa9b9e2fd692b33b40edd35b68 
  docs/upgrades.md 7250259590db322121a0f30d1cdb0f3732a7a6ee 

Diff: https://reviews.apache.org/r/52814/diff/


Testing
---


Thanks,

Kevin Klues