Re: Review Request 54662: Enabled authorization in SET_LOG_LEVEL API call.

2016-12-13 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54662/#review159087 --- Fix it, then Ship it! src/slave/http.cpp (line 904)

Re: Review Request 54662: Enabled authorization in SET_LOG_LEVEL API call.

2016-12-13 Thread Alexander Rojas
> On Dec. 13, 2016, 10:44 a.m., Adam B wrote: > > src/slave/http.cpp, line 898 > > > > > > Is the plan to move everything over to the ObjectApprover API? Why not > > use the simpler

Re: Review Request 54662: Enabled authorization in SET_LOG_LEVEL API call.

2016-12-13 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54662/#review158974 --- Looks good. Just a question about ObjectApprover vs. authorized()

Review Request 54662: Enabled authorization in SET_LOG_LEVEL API call.

2016-12-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54662/ --- Review request for mesos and Adam B. Bugs: MESOS-6670