Re: Review Request 62887: Increased level of some verbose logs from master and agent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/#review188535 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62887/ > --- > > (Updated Oct. 11, 2017, 1:29 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till > Toenshoff. > > > Bugs: MESOS-8072 > https://issues.apache.org/jira/browse/MESOS-8072 > > > Repository: mesos > > > Description > --- > > Increases vlog level of some recurring events to improve readability. > Specifically, we now log the following events on vlog level two > instead of level one: > "Sending heartbeat", > "Received ping from ", > "Querying resource estimator for oversubscribable resources", > "Received oversubscribable resources". > > > Diffs > - > > src/master/master.hpp 0ddc98259f64b3921d08f5f4ec81543bb0826378 > src/slave/slave.cpp c35cf7d72c66bf7cdfd7efa322bd7d73c923fac9 > > > Diff: https://reviews.apache.org/r/62887/diff/1/ > > > Testing > --- > > Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 > --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh > --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 > --work_dir=/tmp/test-mesos/work/` and checked that the new output was as > expected. > > > Thanks, > > Armand Grillet > >
Re: Review Request 62887: Increased level of some verbose logs from master and agent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/#review187713 --- Patch looks great! Reviews applied: [62887] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62887/ > --- > > (Updated Oct. 11, 2017, 1:29 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till > Toenshoff. > > > Bugs: MESOS-8072 > https://issues.apache.org/jira/browse/MESOS-8072 > > > Repository: mesos > > > Description > --- > > Increases vlog level of some recurring events to improve readability. > Specifically, we now log the following events on vlog level two > instead of level one: > "Sending heartbeat", > "Received ping from ", > "Querying resource estimator for oversubscribable resources", > "Received oversubscribable resources". > > > Diffs > - > > src/master/master.hpp 0ddc98259f64b3921d08f5f4ec81543bb0826378 > src/slave/slave.cpp c35cf7d72c66bf7cdfd7efa322bd7d73c923fac9 > > > Diff: https://reviews.apache.org/r/62887/diff/1/ > > > Testing > --- > > Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 > --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh > --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 > --work_dir=/tmp/test-mesos/work/` and checked that the new output was as > expected. > > > Thanks, > > Armand Grillet > >
Re: Review Request 62887: Increased level of some verbose logs from master and agent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/#review187667 --- Ship it! Ship It! - Till Toenshoff On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62887/ > --- > > (Updated Oct. 11, 2017, 1:29 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till > Toenshoff. > > > Bugs: MESOS-8072 > https://issues.apache.org/jira/browse/MESOS-8072 > > > Repository: mesos > > > Description > --- > > Increases vlog level of some recurring events to improve readability. > Specifically, we now log the following events on vlog level two > instead of level one: > "Sending heartbeat", > "Received ping from ", > "Querying resource estimator for oversubscribable resources", > "Received oversubscribable resources". > > > Diffs > - > > src/master/master.hpp 0ddc98259f64b3921d08f5f4ec81543bb0826378 > src/slave/slave.cpp c35cf7d72c66bf7cdfd7efa322bd7d73c923fac9 > > > Diff: https://reviews.apache.org/r/62887/diff/1/ > > > Testing > --- > > Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 > --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh > --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 > --work_dir=/tmp/test-mesos/work/` and checked that the new output was as > expected. > > > Thanks, > > Armand Grillet > >
Re: Review Request 62887: Increased level of some verbose logs from master and agent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/#review187666 --- PASS: Mesos patch 62887 was successfully built and tested. Reviews applied: `['62886', '62887']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62887 - Mesos Reviewbot Windows On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62887/ > --- > > (Updated Oct. 11, 2017, 1:29 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till > Toenshoff. > > > Bugs: MESOS-8072 > https://issues.apache.org/jira/browse/MESOS-8072 > > > Repository: mesos > > > Description > --- > > Increases vlog level of some recurring events to improve readability. > Specifically, we now log the following events on vlog level two > instead of level one: > "Sending heartbeat", > "Received ping from ", > "Querying resource estimator for oversubscribable resources", > "Received oversubscribable resources". > > > Diffs > - > > src/master/master.hpp 0ddc98259f64b3921d08f5f4ec81543bb0826378 > src/slave/slave.cpp c35cf7d72c66bf7cdfd7efa322bd7d73c923fac9 > > > Diff: https://reviews.apache.org/r/62887/diff/1/ > > > Testing > --- > > Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 > --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh > --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 > --work_dir=/tmp/test-mesos/work/` and checked that the new output was as > expected. > > > Thanks, > > Armand Grillet > >
