Re: Review Request 65467: Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/#review197826 --- Ship it! Ship It! - Akash Gupta On Feb. 20, 2018, 7:39 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65467/ > --- > > (Updated Feb. 20, 2018, 7:39 p.m.) > > > Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8512 > https://issues.apache.org/jira/browse/MESOS-8512 > > > Repository: mesos > > > Description > --- > > This function is used on Windows to explicitly enable or disable > inheritance on a handle. > > > Diffs > - > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65467/diff/2/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 65467: Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/#review197796 --- Ship it! Ship It! - Jeff Coffler On Feb. 8, 2018, 10:35 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65467/ > --- > > (Updated Feb. 8, 2018, 10:35 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8512 > https://issues.apache.org/jira/browse/MESOS-8512 > > > Repository: mesos > > > Description > --- > > This function is used on Windows to explicitly enable or disable > inheritance on a handle. > > > Diffs > - > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65467/diff/2/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 65467: Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/#review197193 --- Ship it! Ship It! - Joseph Wu On Feb. 8, 2018, 2:35 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65467/ > --- > > (Updated Feb. 8, 2018, 2:35 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8512 > https://issues.apache.org/jira/browse/MESOS-8512 > > > Repository: mesos > > > Description > --- > > This function is used on Windows to explicitly enable or disable > inheritance on a handle. > > > Diffs > - > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65467/diff/2/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 65467: Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/ --- (Updated Feb. 8, 2018, 2:35 p.m.) Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Changes --- Re-arrange commits. Bugs: MESOS-8512 https://issues.apache.org/jira/browse/MESOS-8512 Repository: mesos Description --- This function is used on Windows to explicitly enable or disable inheritance on a handle. Diffs - 3rdparty/stout/include/stout/internal/windows/inherit.hpp PRE-CREATION Diff: https://reviews.apache.org/r/65467/diff/2/ Testing --- Thanks, Andrew Schwartzmeyer
Re: Review Request 65467: Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/ --- (Updated Feb. 8, 2018, 11:49 a.m.) Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Changes --- Make it `set(bool)` so it can be used to turn things on and off. Summary (updated) - Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`. Bugs: MESOS-8512 https://issues.apache.org/jira/browse/MESOS-8512 Repository: mesos Description (updated) --- This function is used on Windows to explicitly enable or disable inheritance on a handle. Diffs (updated) - 3rdparty/stout/include/stout/internal/windows/inherit.hpp PRE-CREATION Diff: https://reviews.apache.org/r/65467/diff/2/ Changes: https://reviews.apache.org/r/65467/diff/1-2/ Testing --- Thanks, Andrew Schwartzmeyer
