Re: Review Request 67923: Improved performance of cgroups::read by verifying after failure.

2018-07-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67923/#review206142 --- Ship it! Ship It! - Gilbert Song On July 15, 2018, 7:03

Re: Review Request 67923: Improved performance of cgroups::read by verifying after failure.

2018-07-16 Thread Benjamin Mahler
> On July 16, 2018, 8:54 p.m., Jie Yu wrote: > > LGTM! Thanks Ben. I think longer term, we will modify caller to call > > `verify`, making read/write/create pure helper for writing to cgroup > > filesystem. Yeah, I'll copy the longer options from the commit description into a TODO so it's

Re: Review Request 67923: Improved performance of cgroups::read by verifying after failure.

2018-07-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67923/#review206128 --- Ship it! LGTM! Thanks Ben. I think longer term, we will modify

Re: Review Request 67923: Improved performance of cgroups::read by verifying after failure.

2018-07-16 Thread Stéphane Cottin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67923/#review206095 --- Ship it! Ship It! - Stéphane Cottin On July 16, 2018, 2:03

Re: Review Request 67923: Improved performance of cgroups::read by verifying after failure.

2018-07-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67923/#review206093 --- PASS: Mesos patch 67923 was successfully built and tested.

Review Request 67923: Improved performance of cgroups::read by verifying after failure.

2018-07-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67923/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-8418