Re: Review Request 69205: Fixed FetcherTest.DuplicateFileURI on OSX.

2018-10-30 Thread Joseph Wu
> On Oct. 30, 2018, 11:48 a.m., Benjamin Bannier wrote: > > src/common/type_utils.cpp > > Lines 86 (patched) > > > > > > Not yours, but it would be great to document that we don't want to > > include `cache`

Re: Review Request 69205: Fixed FetcherTest.DuplicateFileURI on OSX.

2018-10-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69205/#review210177 --- Fix it, then Ship it! src/common/type_utils.cpp Lines 86

Re: Review Request 69205: Fixed FetcherTest.DuplicateFileURI on OSX.

2018-10-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69205/#review210159 --- PASS: Mesos patch 69205 was successfully built and tested.

Review Request 69205: Fixed FetcherTest.DuplicateFileURI on OSX.

2018-10-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69205/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9357