On June 24, 2015, 6:41 p.m., Ben Mahler wrote:
Actually, we should think about one more thing, how does this interact with
the zookeeper session timeout?
Adam B wrote:
The hardcoded individual ping timeout (15secs) was previously longer than
the default zk session timeout
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated June 26, 2015, 3:12 a.m.)
Review request for mesos, Ben Mahler and
On June 3, 2015, 2:24 p.m., Ben Mahler wrote:
src/tests/partition_tests.cpp, lines 647-650
https://reviews.apache.org/r/29507/diff/7/?file=973888#file973888line647
This sounds like testing two particular behaviors in a single test:
(1) A registered slave that never
On June 25, 2015, 1:41 a.m., Ben Mahler wrote:
Actually, we should think about one more thing, how does this interact with
the zookeeper session timeout?
Adam B wrote:
The hardcoded individual ping timeout (15secs) was previously longer than
the default zk session timeout
On June 24, 2015, 6:41 p.m., Ben Mahler wrote:
Actually, we should think about one more thing, how does this interact with
the zookeeper session timeout?
The hardcoded individual ping timeout (15secs) was previously longer than the
default zk session timeout (10secs), but the zk session
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review89482
---
Patch looks great!
Reviews applied: [29507]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review89305
---
Actually, we should think about one more thing, how does this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review89243
---
Ship it!
Ship It!
- Niklas Nielsen
On June 22, 2015, 3:03 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review88761
---
Patch looks great!
Reviews applied: [29507]
All tests passed.
-
On June 1, 2015, 1:15 p.m., Niklas Nielsen wrote:
LGTM - Would it make sense to have sane min/max values for the
timeouts/counts?
I wonder it would make sense to have a test to exercise an upgrade path
(the timeout being different in the slaves, than in the master). Maybe I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated June 22, 2015, 3:03 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review86039
---
LGTM - Would it make sense to have sane min/max values for the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated May 28, 2015, 4:13 p.m.)
Review request for mesos, Ben Mahler and
On May 14, 2015, 6:07 a.m., Alexander Rukletsov wrote:
src/master/master.cpp, line 1315
https://reviews.apache.org/r/29507/diff/6/?file=959052#file959052line1315
This looks like a drive-by bug fix, should it be included in this diff?
At least, let's mention it in the description.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review85652
---
Patch looks great!
Reviews applied: [29507]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review84726
---
Hey Adam, is this ready for review?
- Niklas Nielsen
On May 14,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated May 14, 2015, 1:54 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated May 14, 2015, 3:01 a.m.)
Review request for mesos, Ben Mahler and
18 matches
Mail list logo
