Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-07-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review91875 --- 3rdparty/libprocess/src/tests/process_tests.cpp (lines 1757 -

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-07-16 Thread Alexander Rojas
On July 9, 2015, 9:19 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/process.cpp, lines 2815-2819 https://reviews.apache.org/r/30032/diff/14/?file=986489#file986489line2815 Any reason we didn't convert os::stat::mtime to return a Time? The only other user of

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-07-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review91103 --- Ship it! 3rdparty/libprocess/src/tests/process_tests.cpp (line

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-07-09 Thread Till Toenshoff
On July 9, 2015, 7:19 p.m., Ben Mahler wrote: Thanks for looking into this Ben - we will shortly propose a fix for the current test break on Ubuntu and also most of these nits. - Till --- This is an automatically generated e-mail.

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-07-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review91149 --- 3rdparty/libprocess/src/process.cpp (lines 2815 - 2819)

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-07-09 Thread Till Toenshoff
On July 9, 2015, 7:19 p.m., Ben Mahler wrote: Till Toenshoff wrote: Thanks for looking into this Ben - we will shortly propose a fix for the current test break on Ubuntu and also most of these nits. We decided to revert that commit instead for now until we can thorroughly fix this

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-07-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review90672 --- Ship it! If/when RR 34703 ships first, please fix this TODO: //

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review88211 --- Well done! An very nice test code.

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-17 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated June 17, 2015, 5:42 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review88240 --- Patch looks great! Reviews applied: [34703, 30032] All tests

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-17 Thread Alexander Rojas
On June 17, 2015, 4 p.m., Bernd Mathiske wrote: 3rdparty/libprocess/src/process.cpp, line 2842 https://reviews.apache.org/r/30032/diff/13/?file=986200#file986200line2842 Here we can output mtime.error(). This one is a bad place since here `strftime` failed, which is unrelated to

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated June 17, 2015, 4:08 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated June 16, 2015, 9:53 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated June 15, 2015, 5:27 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review87939 --- Patch looks great! Reviews applied: [34703, 30032] All tests

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review87041 --- Patch looks great! Reviews applied: [34703, 30032] All tests

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-27 Thread Alexander Rojas
On May 20, 2015, 7:10 a.m., Nikita Vetoshkin wrote: 3rdparty/libprocess/include/process/http.hpp, line 352 https://reviews.apache.org/r/30032/diff/7/?file=963338#file963338line352 strftime formatting is locale dependent. This example ``` #include locale.h #include

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated May 27, 2015, 4:50 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review85384 --- Patch looks great! Reviews applied: [34392, 34703, 30032] All

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review85296 --- Patch looks great! Reviews applied: [34392, 30032] All tests

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review85183 --- 3rdparty/libprocess/include/process/http.hpp

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated May 26, 2015, 4:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-26 Thread Alexander Rojas
On May 22, 2015, 5:03 p.m., Bernd Mathiske wrote: 3rdparty/libprocess/src/process.cpp, line 2708 https://reviews.apache.org/r/30032/diff/7/?file=963339#file963339line2708 Why Result and not Try? Why not propagate the error from mtime? Why snake_case and not camelCase?

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-22 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review84908 --- First pass. 3rdparty/libprocess/include/process/http.hpp

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-20 Thread Nikita Vetoshkin
On May 20, 2015, 5:10 a.m., Nikita Vetoshkin wrote: 3rdparty/libprocess/include/process/http.hpp, line 352 https://reviews.apache.org/r/30032/diff/7/?file=963338#file963338line352 strftime formatting is locale dependent. This example ``` #include locale.h #include

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-20 Thread Alexander Rojas
On May 20, 2015, 7:10 a.m., Nikita Vetoshkin wrote: 3rdparty/libprocess/include/process/http.hpp, line 352 https://reviews.apache.org/r/30032/diff/7/?file=963338#file963338line352 strftime formatting is locale dependent. This example ``` #include locale.h #include

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-19 Thread Nikita Vetoshkin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review84465 --- 3rdparty/libprocess/include/process/http.hpp

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
On March 26, 2015, 5:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); This cannot be implemented in terms on `Time`, since `Path`

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Till Toenshoff
On March 26, 2015, 4:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); Alexander Rojas wrote: This cannot be implemented in

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
On March 26, 2015, 5:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); Alexander Rojas wrote: This cannot be implemented in

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated May 19, 2015, 6:20 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
On March 26, 2015, 5:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); Alexander Rojas wrote: This cannot be implemented in