Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-07-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review90757 --- Bad patch! Reviews applied: [32891, 31444] Failed command:

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-07-07 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/ --- (Updated July 7, 2015, 11:33 a.m.) Review request for mesos, Chi Zhang,

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-07-06 Thread Ian Downes
On June 29, 2015, 4:29 p.m., Jiang Yan Xu wrote: src/slave/containerizer/mesos/launch.cpp, lines 64-65 https://reviews.apache.org/r/31444/diff/7/?file=989735#file989735line64 must be relative to is really is interpreted as relative to right? Just wanted be sure clarify:

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review89425 --- src/slave/containerizer/mesos/launch.cpp (lines 64 - 65)

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review88814 --- src/tests/launch_tests.cpp (lines 118 - 120)

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review88581 --- Ship it! LGTM overall. Had some question about the bind mount in

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-19 Thread Ian Downes
On June 19, 2015, 2:06 p.m., Jie Yu wrote: src/tests/launch_tests.cpp, lines 96-101 https://reviews.apache.org/r/31444/diff/6/?file=975951#file975951line96 Can you explain why this is needed? Maybe add a comment or something? If this is not strictly needed, I would remove it

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-16 Thread Ian Downes
On June 4, 2015, 11:32 a.m., Chi Zhang wrote: src/tests/launch_tests.cpp, line 91 https://reviews.apache.org/r/31444/diff/6/?file=975951#file975951line91 for discussion: this requires these directories not existent in rootfs. should we specify requirements for the structure under

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-04 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review86675 --- src/slave/containerizer/mesos/launch.cpp

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review86122 --- Patch looks great! Reviews applied: [32891, 32978, 31444] All

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-05-26 Thread Ian Downes
On April 13, 2015, 3:49 p.m., Jie Yu wrote: src/tests/launch_tests.cpp, lines 109-110 https://reviews.apache.org/r/31444/diff/4/?file=920907#file920907line109 Why slave mount? Shouldn't this be a SHARED mount? No, we want this as a slave mount, i.e., no back propagation. - Ian

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-05-12 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/ --- (Updated May 12, 2015, 5:22 p.m.) Review request for mesos, Chi Zhang, Dominic

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review83553 --- Patch looks great! Reviews applied: [32891, 32978, 31444] All