Re: Review Request 32384: Adding perf check to configure

2015-07-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32384/#review90428 --- Ship it! Your check for 'perf' in the configuration is really not

Re: Review Request 32384: Adding perf check to configure

2015-07-05 Thread Benjamin Hindman
On July 2, 2015, 11:45 a.m., haosdent huang wrote: configure.ac, line 1121 https://reviews.apache.org/r/32384/diff/2/?file=998167#file998167line1121 Seems other exist checks use AC_CHECK_TOOL, such as ``` AC_CHECK_TOOL([PROTOCOMPILER_TEST], [protoc], [],

Re: Review Request 32384: Adding perf check to configure

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32384/#review90380 --- Patch looks great! Reviews applied: [32384] All tests passed. -

Re: Review Request 32384: Adding perf check to configure

2015-07-02 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32384/ --- (Updated July 2, 2015, 8:09 a.m.) Review request for mesos and Cody Maloney.

Re: Review Request 32384: Adding perf check to configure

2015-07-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32384/#review90210 --- Ship it! Ship It! configure.ac (line 1121)