---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/#review83609
---
Ship it!
Ship It!
- Alexander Rukletsov
On May 12, 2015, 6:44
On April 24, 2015, 8:18 a.m., Alexander Rukletsov wrote:
src/common/resources.cpp, lines 442-445
https://reviews.apache.org/r/32398/diff/2/?file=921003#file921003line442
Let's use this function where we already check for this condition, like
in `master/validation.cpp` in
On May 13, 2015, 6:04 p.m., Jie Yu wrote:
I fixed a few style issues for you. Make sure the comments are wrapped at
70 chars (set tw=70).
Also, this is how I used to find snake case variable names:
`/[a-z]*_[a-z]*\ `
I fixed a few style issues for you.
Thank you... and sorry.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/
---
(Updated May 12, 2015, 6:44 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/#review83464
---
Patch looks great!
Reviews applied: [32139, 32140, 32149, 32150,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/
---
(Updated May 11, 2015, 8:36 p.m.)
Review request for mesos and Alexander
On April 8, 2015, 11:49 p.m., Jie Yu wrote:
src/common/resources.cpp, lines 442-445
https://reviews.apache.org/r/32398/diff/2/?file=921003#file921003line442
Since we already have `isReserved`. How about calling it
`isDynamicallyReserved`?
Good idea, Fixed :)
On April 8, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/#review83321
---
Patch looks great!
Reviews applied: [32139, 32140, 32149, 32150,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/
---
(Updated May 11, 2015, 10:25 p.m.)
Review request for mesos and Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/
---
(Updated May 11, 2015, 10:29 p.m.)
Review request for mesos and Alexander
10 matches
Mail list logo