Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review141523 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2016-01-16 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review114895 --- src/tests/fetcher_tests.cpp (line 706)

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2016-01-13 Thread Adam B
> On April 21, 2015, 10:30 a.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [32975] > > > > All tests passed. Jim, I heard there was interest in reviving this patch. Could you please rebase? - Adam --- This

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-29 Thread Adam B
> On April 8, 2015, 2:57 p.m., Vinod Kone wrote: > > src/tests/fetcher_tests.cpp, lines 112-116 > > > > > > Add a note/todo here mentioning why you are setting these fields but > > not doing any asserts/expects on the

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-22 Thread Jim Klucar
> On April 8, 2015, 9:57 p.m., Vinod Kone wrote: > > src/tests/fetcher_tests.cpp, lines 112-116 > > > > > > Add a note/todo here mentioning why you are setting these fields but > > not doing any asserts/expects on the

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-22 Thread Adam B
> On April 8, 2015, 2:57 p.m., Vinod Kone wrote: > > src/tests/fetcher_tests.cpp, lines 112-116 > > > > > > Add a note/todo here mentioning why you are setting these fields but > > not doing any asserts/expects on the