Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review86783 --- Patch looks great! Reviews applied: [32961, 33159] All tests

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review86781 --- Ship it! src/master/allocator/mesos/hierarchical.hpp

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/ --- (Updated June 5, 2015, 8:53 a.m.) Review request for mesos and Benjamin

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/ --- (Updated June 5, 2015, 1:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Vinod Kone
On June 5, 2015, 5:42 p.m., Vinod Kone wrote: src/master/allocator/mesos/hierarchical.hpp, lines 455-456 https://reviews.apache.org/r/33159/diff/4/?file=979945#file979945line455 I don't follow. Why are these CHECKs? Is there currently code in the master that guarantees that these

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review86818 --- src/master/allocator/mesos/hierarchical.hpp

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-05-29 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/ --- (Updated May 29, 2015, 10:41 p.m.) Review request for mesos and Benjamin

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-05-22 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review84882 --- Ship it! src/master/master.cpp

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-05-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review84893 --- src/master/allocator/mesos/hierarchical.hpp